linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Chris Healy <cphealy@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Aleksander Morgado <aleksander@aleksander.es>
Subject: Re: [PATCH v3 2/2] nvmem: Add RAVE SP EEPROM driver
Date: Wed, 2 May 2018 09:24:21 +0100	[thread overview]
Message-ID: <2733c63f-f7c6-cdbc-e725-03126d8a7ed5@linaro.org> (raw)
In-Reply-To: <CAHQ1cqGmiRvE+sUdpOcFQ=oGjA79sVQGc+noQBv7SP_0rKggvw@mail.gmail.com>



On 01/05/18 19:35, Andrey Smirnov wrote:
> On Tue, May 1, 2018 at 8:33 AM, Srinivas Kandagatla
> <srinivas.kandagatla@linaro.org> wrote:
>>
>>
>> On 01/05/18 06:29, Andrey Smirnov wrote:
>>>
>>> +// SPDX-License-Identifier: GPL-2.0+
>>
>> ...
>>>
>>> +MODULE_LICENSE("GPL");
>>
>> I think this should be
>> MODULE_LICENSE("GPL v2");
> 
> With that change the two statements would contradict each other. "GPL"
> means "GNU Public License v2 or later", whereas "GPL v2" means "GNU
> Public License v2" as per
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175
> 
Yep, You are correct, I missed the +.
I will send these patches to Greg during rc4-rc5 time.

thanks,
srini

      reply	other threads:[~2018-05-02  8:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01  5:29 [PATCH v3 0/2] RAVE SP EEPROM driver Andrey Smirnov
2018-05-01  5:29 ` [PATCH v3 1/2] dt-bindings: nvmem: Add binding for " Andrey Smirnov
2018-05-01 12:50   ` Rob Herring
2018-05-01  5:29 ` [PATCH v3 2/2] nvmem: Add " Andrey Smirnov
2018-05-01 15:33   ` Srinivas Kandagatla
2018-05-01 18:35     ` Andrey Smirnov
2018-05-02  8:24       ` Srinivas Kandagatla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2733c63f-f7c6-cdbc-e725-03126d8a7ed5@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=aleksander@aleksander.es \
    --cc=andrew.smirnov@gmail.com \
    --cc=cphealy@gmail.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).