From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>, ilia.lin@gmail.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] cpufreq: kryo: Add module remove and exit
Date: Thu, 21 Jun 2018 15:23:11 +0200 [thread overview]
Message-ID: <2736020.lelA2SSAlr@aspire.rjw.lan> (raw)
In-Reply-To: <20180618045550.sasilydvnlsmxzpk@vireshk-i7>
On Monday, June 18, 2018 6:55:50 AM CEST Viresh Kumar wrote:
> On 17-06-18, 22:01, ilia.lin@gmail.com wrote:
> > From: Ilia Lin <ilia.lin@gmail.com>
> >
> > Add device remove and module exit code to make the driver
> > functioning as a loadable module.
> >
> > Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
> > Signed-off-by: Ilia Lin <ilia.lin@gmail.com>
> > ---
> > drivers/cpufreq/qcom-cpufreq-kryo.c | 22 +++++++++++++++++++---
> > 1 file changed, 19 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > index 74b9b93d511b..01bddacf5c3b 100644
> > --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> > +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > @@ -42,6 +42,8 @@ enum _msm8996_version {
> > NUM_OF_MSM8996_VERSIONS,
> > };
> >
> > +struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
> > +
> > static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> > {
> > size_t len;
> > @@ -74,7 +76,6 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> > static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> > {
> > struct opp_table *opp_tables[NR_CPUS] = {0};
> > - struct platform_device *cpufreq_dt_pdev;
> > enum _msm8996_version msm8996_version;
> > struct nvmem_cell *speedbin_nvmem;
> > struct device_node *np;
> > @@ -165,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> > return ret;
> > }
> >
> > +static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
> > +{
> > + platform_device_unregister(cpufreq_dt_pdev);
> > + return 0;
> > +}
> > +
> > static struct platform_driver qcom_cpufreq_kryo_driver = {
> > .probe = qcom_cpufreq_kryo_probe,
> > + .remove = qcom_cpufreq_kryo_remove,
> > .driver = {
> > .name = "qcom-cpufreq-kryo",
> > },
> > @@ -201,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
> > if (unlikely(ret < 0))
> > return ret;
> >
> > - ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
> > - "qcom-cpufreq-kryo", -1, NULL, 0));
> > + kryo_cpufreq_pdev = platform_device_register_simple(
> > + "qcom-cpufreq-kryo", -1, NULL, 0);
> > + ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
> > if (0 == ret)
> > return 0;
> >
> > @@ -211,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
> > }
> > module_init(qcom_cpufreq_kryo_init);
> >
> > +static void __init qcom_cpufreq_kryo_exit(void)
> > +{
> > + platform_device_unregister(kryo_cpufreq_pdev);
> > + platform_driver_unregister(&qcom_cpufreq_kryo_driver);
> > +}
> > +module_exit(qcom_cpufreq_kryo_exit);
> > +
> > MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
> > MODULE_LICENSE("GPL v2");
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Patch applied, thanks!
prev parent reply other threads:[~2018-06-21 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 20:58 [PATCH] cpufreq: kryo: Add module remove and exit ilia.lin
2018-06-08 4:29 ` Viresh Kumar
2018-06-14 20:42 ` [PATCH v2] " ilia.lin
2018-06-15 2:45 ` Viresh Kumar
2018-06-17 20:01 ` [PATCH v3] " ilia.lin
2018-06-18 4:55 ` Viresh Kumar
2018-06-21 13:23 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2736020.lelA2SSAlr@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=ilia.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).