From: Matthias Brugger <matthias.bgg@gmail.com>
To: Ansuel Smith <ansuelsmth@gmail.com>, Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-arm-kernel@axis.com,
linux-aspeed@lists.ozlabs.org,
linux-rpi-kernel@lists.infradead.org,
chrome-platform@lists.linux.dev,
linux-renesas-soc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
kernel@dh-electronics.com, linux-mediatek@lists.infradead.org,
openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
linux-oxnas@groups.io, linux-arm-msm@vger.kernel.org,
linux-unisoc@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-realtek-soc@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Subject: Re: [RFC PATCH 0/1] Categorize ARM dts directory
Date: Thu, 27 Apr 2023 09:34:58 +0200 [thread overview]
Message-ID: <273a9ff1-ceb2-bcf6-b3a5-be34746ed45f@gmail.com> (raw)
In-Reply-To: <CA+_ehUw3eAEHRsi1ATSKeK4jtX+EoVSwUodNL3bcpTJaX-r9cA@mail.gmail.com>
On 25/04/2023 00:23, Ansuel Smith wrote:
> Il giorno mar 25 apr 2023 alle ore 00:10 Rob Herring
> <robh+dt@kernel.org> ha scritto:
>>
>> On Tue, Mar 29, 2022 at 8:27 AM Ansuel Smith <ansuelsmth@gmail.com> wrote:
>>>
>>> On Tue, Mar 29, 2022 at 03:20:18PM +0200, Krzysztof Kozlowski wrote:
>>>> On 28/03/2022 02:09, Ansuel Smith wrote:
>>>>> Hi,
>>>>> as the title say, the intention of this ""series"" is to finally categorize
>>>>> the ARM dts directory in subdirectory for each oem.
>>>>>
>>>>> The main reason for this is that it became unpractical to handle 2600
>>>>> dts files and try to even understand/edit/check the situation for a
>>>>> specific target.
>>>>>
>>>>> In arm64 we already have this kind of separation and I honestly think
>>>>> that this was never proposed for ARM due to the fact that there are
>>>>> 2600+ files to sort and the fact that it will be a mess to merge this
>>>>> entirely but IMHO with a little bit of effort we can finally solve this
>>>>> problem and have a well organized directory just like arm64.
>>>>>
>>>>> Some prerequisite on how this work was done:
>>>>> - This comes entirely from a python script created by me for the task.
>>>>> linked here [1]
>>>>> - I had to manually categorize all the different arch in the makefile
>>>>> based on the oem. I searched every arch on the internet trying to
>>>>> understand the correct oem. I hope they are correct but I would love
>>>>> some comments about them.
>>>>> - This current ""series"" is all squashed in one big commit to better
>>>>> receive comments for this. The final version ideally would have all
>>>>> changes in separate commits. The script can already do this, it's just
>>>>> commented.
>>>>>
>>>>> Here is a list of some discoveries while doing all the sorting.
>>>>> These are totally additional reason why we need this.
>>>>>
>>>>> While creating the script I discovered some funny things:
>>>>> - We have orphan dts! There are dts that are never compiled and are
>>>>> there just for reference. We would never have noticed this without this
>>>>> change and probably nobody noticed it. They are currently all listed
>>>>> in the python script.
>>>>> - We have dtsi shared across different oem. My current solution for them
>>>>> is: NOT SORT THEM and leave them in the generic directory and create a
>>>>> link in each oem dts that points to these dtsi. This is to try in
>>>>> every way possible to skip any additional changes to the dts.
>>>>> Current dtsi that suffers from this are only 3. (listed in the script)
>>>>> - arm64 dts and dtsi reference ARM dts. Obviously this change would cause
>>>>> broken include for these special dtsi. The script creates a dependency
>>>>> table of the entire arm64 directory and fix every broken dependency
>>>>> (hoping they all use a sane include logic... regex is used to parse
>>>>> all the different dependency)
>>>>>
>>>>> So in short the script does the following steps:
>>>>> 1. Enumerate all the action to do... (dts to move, scan dependency for
>>>>> the dts...)
>>>>> 2. Generate the arm64 dependency
>>>>> 3. Creates the Makefile
>>>>> 4. Generate the Makefiles for the current oem
>>>>> 5. Move all the related dts and dtsi for the current oem
>>>>> 6. Check broken dependency and fix them by editing the dts and writing
>>>>> the correct include (or fix any symbolic link)
>>>>>
>>>>> This is an output that describes all the things done by the script [2]
>>>>>
>>>>> I really hope I didn't commit any logic mistake in the script but most
>>>>> of the work should be done.
>>>>>
>>>>
>>>> +Cc Arnd and Olof,
>>>>
>>>> Ansuel,
>>>> Thanks for you patch. Please cc the SoC maintainers in such submissions.
>>>> It seems that you got some quite nice discussion, but still the core
>>>> folks are not Cced, so no one would be able to take your patch...
>>>>
>>>
>>> I had some problem with gmail and sending mail too much users. I put Rob
>>> and You and all the various list to try to workaround the "gmail spam
>>> protection"
>>>
>>>> I am pretty sure we were discussing such split idea in the past and it
>>>> did not get traction, but I cannot recall the exact discussion.
>>>>
>>>
>>> I think the main issue here is how to handle bot and how problematic is
>>> to merge this. As written in the cover letter the final version of this
>>> should be a big series of 50+ patch with every commit specific to each
>>> oem. In theory we should be able to merge the different oem separately
>>> and try to at least start the categorization.
>>> Another idea I got to at least have a "migration path" is to convert
>>> every dts in the dts/ directory to a symbolic link that target the dts
>>> in the correct oem. But I assume that would fix only part of the problem
>>> and git am will still be problematic.
>>
>> I have a script[1] that does the conversion written the last time this
>> came up. Just have to agree on directory names. I think the easiest
>> would be for Arnd/Olof to run it at the end of a merge window before
>> rc1.
>>
>> I'm very much in favor of this happening especially before *any*
>> overlays are added to add to the mess (it's probably already
>> happened).
>>
>> Rob
>>
>> [1] https://lore.kernel.org/all/20181204183649.GA5716@bogus/
>
> Hi Rob,
> thanks for recovering this. I remember also providing a script.
>
> Anyway considering the amount of stuff to move, I feel like some
> OEM might be problematic to move due to rebase and merging problems.
>
> We should consider accepting moving only some and keep other
> in the unsorted path. And move them at the first time possible with
> the help of the maintainers.
>
> One main blocker of this is some qcom dts that are linked to arm64
> directory, so for some dts special care is needed.
>
Same happens for broadcom RaspberryPi DTS. The arm64 ones include the arm ones.
Regards,
Matthias
next prev parent reply other threads:[~2023-04-27 7:35 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 0:09 [RFC PATCH 0/1] Categorize ARM dts directory Ansuel Smith
2022-03-28 0:09 ` [RFC PATCH 1/1] ARM/arm64: categorize dts in arm dir and fix dependency in arm64 Ansuel Smith
2022-03-28 7:57 ` [PATCH RFC " Geert Uytterhoeven
2022-03-28 8:28 ` [RFC PATCH " Jesper Nilsson
2022-03-28 11:55 ` Ansuel Smith
2022-03-28 9:09 ` [Linux-stm32] " Patrice CHOTARD
2022-03-28 9:20 ` Patrice CHOTARD
2022-03-28 11:59 ` Ansuel Smith
2022-03-28 12:11 ` Patrice CHOTARD
2022-03-28 10:47 ` Matthias Brugger
2022-03-28 11:54 ` Ansuel Smith
2022-03-29 13:03 ` Romain Perier
2022-03-28 8:55 ` [RFC PATCH 0/1] Categorize ARM dts directory Daniel Palmer
2022-03-29 7:53 ` Tony Lindgren
2022-03-29 8:32 ` Andrew Jeffery
2022-03-29 9:04 ` Geert Uytterhoeven
2022-03-29 9:54 ` Tony Lindgren
2022-03-29 10:06 ` Matthias Brugger
2022-03-29 8:50 ` Nicolas Ferre
2023-04-25 16:21 ` Robin Murphy
2023-05-02 19:01 ` Rob Herring
2022-03-28 13:21 ` Jonathan Neuschäfer
2022-03-28 13:27 ` Ansuel Smith
2022-03-28 13:35 ` Jonathan Neuschäfer
2022-03-28 13:50 ` H. Nikolaus Schaller
2022-03-29 0:23 ` Andrew Jeffery
2022-03-28 14:00 ` (EXT) " Alexander Stein
2022-03-29 9:19 ` Alexandre Belloni
2022-03-29 13:20 ` Krzysztof Kozlowski
2022-03-29 4:56 ` Ansuel Smith
2023-04-24 22:10 ` Rob Herring
2023-04-24 22:23 ` Ansuel Smith
2023-04-27 7:34 ` Matthias Brugger [this message]
2023-04-25 7:27 ` Geert Uytterhoeven
2023-04-25 15:57 ` Rob Herring
2023-04-27 7:37 ` Matthias Brugger
2023-04-27 7:46 ` Geert Uytterhoeven
2023-04-27 7:48 ` Tony Lindgren
2023-05-02 8:15 ` Arnd Bergmann
2023-05-02 19:40 ` Rob Herring
2023-05-02 20:02 ` Krzysztof Kozlowski
2023-05-03 1:19 ` Shawn Guo
2023-05-03 10:43 ` Arnd Bergmann
2023-05-02 21:18 ` Linus Walleij
2023-05-02 21:27 ` Rob Herring
2023-05-02 22:01 ` Christian Hewitt
2023-05-03 10:42 ` Neil Armstrong
2023-05-02 22:52 ` Dmitry Baryshkov
2023-05-03 1:17 ` Rob Herring
2023-05-03 10:38 ` Arnd Bergmann
2023-05-03 12:13 ` Dmitry Baryshkov
2023-05-03 12:18 ` Arnd Bergmann
2023-05-03 13:16 ` Rob Herring
2023-05-03 20:37 ` Arnd Bergmann
2023-05-03 20:39 ` Linus Walleij
2023-05-03 22:22 ` Rob Herring
2023-05-02 23:02 ` Florian Fainelli
2023-05-03 1:04 ` Rob Herring
2023-05-03 22:29 ` Florian Fainelli
2023-05-03 5:57 ` Tony Lindgren
2023-05-03 8:56 ` Geert Uytterhoeven
2023-05-03 11:02 ` Arnd Bergmann
2023-05-03 13:08 ` Rob Herring
2023-05-03 20:25 ` Linus Walleij
2023-05-04 7:09 ` [Linux-stm32] " Alexandre TORGUE
2023-05-03 12:01 ` Jesper Nilsson
2023-05-04 10:11 ` Russell King (Oracle)
2023-05-04 11:44 ` Arnd Bergmann
2023-05-09 22:54 ` Jonathan Neuschäfer
2023-06-08 20:33 ` Rob Herring
2023-04-25 8:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=273a9ff1-ceb2-bcf6-b3a5-be34746ed45f@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=ansuelsmth@gmail.com \
--cc=arnd@arndb.de \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=kernel@dh-electronics.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-oxnas@groups.io \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-unisoc@lists.infradead.org \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).