From: shuah <shuah@kernel.org>
To: Mao Wenan <maowenan@huawei.com>,
valentina.manea.m@gmail.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, shuah <shuah@kernel.org>
Subject: Re: [PATCH v2] usbip: vhci_hcd indicate failed message
Date: Mon, 16 Sep 2019 07:18:30 -0600 [thread overview]
Message-ID: <2743ad5b-9348-bd2b-4763-a2a199e6edad@kernel.org> (raw)
In-Reply-To: <20190915142223.158404-1-maowenan@huawei.com>
On 9/15/19 8:22 AM, Mao Wenan wrote:
> If the return value of vhci_init_attr_group and
> sysfs_create_group is non-zero, which mean they failed
> to init attr_group and create sysfs group, so it would
> better add 'failed' message to indicate that.
> This patch also change pr_err to dev_err to trace which
> device is failed.
>
> Fixes: 0775a9cbc694 ("usbip: vhci extension: modifications to vhci driver")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> v2: change pr_err to dev_err.
> drivers/usb/usbip/vhci_hcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 000ab7225717..bea28ec846ee 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1185,12 +1185,12 @@ static int vhci_start(struct usb_hcd *hcd)
> if (id == 0 && usb_hcd_is_primary_hcd(hcd)) {
> err = vhci_init_attr_group();
> if (err) {
> - pr_err("init attr group\n");
> + dev_err(hcd_dev(hcd), "init attr group failed\n");
Why not include err information in the message. Helps figure out why
it failed.
> return err;
> }
> err = sysfs_create_group(&hcd_dev(hcd)->kobj, &vhci_attr_group);
> if (err) {
> - pr_err("create sysfs files\n");
> + dev_err(hcd_dev(hcd), "create sysfs files failed\n");
> vhci_finish_attr_group();
> return err;
> }
>
Why not include err information in the message. Helps figure out why
it failed.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-09-16 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-15 3:43 [PATCH] usbip: vhci_hcd indicate failed message Mao Wenan
2019-09-15 12:52 ` Greg KH
2019-09-15 13:31 ` walter harms
2019-09-15 14:22 ` [PATCH v2] " Mao Wenan
2019-09-16 13:18 ` shuah [this message]
2019-09-16 15:09 ` [PATCH v3] " Mao Wenan
2019-09-16 15:47 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2743ad5b-9348-bd2b-4763-a2a199e6edad@kernel.org \
--to=shuah@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).