From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] ASoC: tlv320aic31xx: Add overflow detection support
Date: Tue, 4 Sep 2018 09:38:24 -0500 [thread overview]
Message-ID: <274b9d82-542b-dbf7-94e2-a61bc6eb2bbc@ti.com> (raw)
In-Reply-To: <20180903130318.GH10302@sirena.org.uk>
On 09/03/2018 08:03 AM, Mark Brown wrote:
> On Fri, Aug 31, 2018 at 01:24:32PM -0500, Andrew F. Davis wrote:
>> Similar to short circuit detection, when the ADC/DAC is saturated and
>> overflows poor audio quality can result and should be reported to the
>> user. This device support Automatic Dynamic Range Compression (DRC)
>> to reduce this but it is not enabled currently in this driver.
>
>> + if (value & AIC31XX_DAC_OF_LEFT)
>> + dev_err(dev, "Left-channel DAC overflow has occurred\n");
>> + if (value & AIC31XX_DAC_OF_RIGHT)
>> + dev_err(dev, "Right-channel DAC overflow has occurred\n");
>
> So, this will sound terrible but I'm not sure that unconditionally
> shouting in the logs is the right thing to do here - people do sometimes
> put non-audio signals through sound cards (using them as generic DACs
> and ADCs) and it seems like it could get very spammy. Perhaps a lower
> level warning message, some counters or even some control that allows
> the warnings to be masked.
>
As these events do not stop the function of the sound card, I agree
warnings would be more appropriate than errors, I'll make that change.
Andrew
next prev parent reply other threads:[~2018-09-04 14:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 18:24 [PATCH 1/4] ASoC: tlv320aic31xx: Add short circuit detection support Andrew F. Davis
2018-08-31 18:24 ` [PATCH 2/4] ASoC: tlv320aic31xx: Add overflow " Andrew F. Davis
2018-09-03 13:03 ` Mark Brown
2018-09-04 14:38 ` Andrew F. Davis [this message]
2018-08-31 18:24 ` [PATCH 3/4] ASoC: tlv320aic31xx: Add headphone/headset detection Andrew F. Davis
2018-09-03 13:05 ` Mark Brown
2018-08-31 18:24 ` [PATCH 4/4] ASoC: tlv320aic31xx: Add button press detection Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=274b9d82-542b-dbf7-94e2-a61bc6eb2bbc@ti.com \
--to=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).