From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A3CC43331 for ; Fri, 3 Apr 2020 17:50:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 592492077D for ; Fri, 3 Apr 2020 17:50:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403886AbgDCRuF (ORCPT ); Fri, 3 Apr 2020 13:50:05 -0400 Received: from smtprelay0005.hostedemail.com ([216.40.44.5]:46942 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727882AbgDCRuF (ORCPT ); Fri, 3 Apr 2020 13:50:05 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id C898A182CED34; Fri, 3 Apr 2020 17:50:03 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: train70_1d5dccc9e8c04 X-Filterd-Recvd-Size: 2521 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Fri, 3 Apr 2020 17:50:01 +0000 (UTC) Message-ID: <2751400ae13b25d8259a8a9d7b36caf98ec2d367.camel@perches.com> Subject: Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs From: Joe Perches To: Mauro Carvalho Chehab Cc: Rasmus Villemoes , Sakari Ailus , Petr Mladek , Andy Shevchenko , linux-media@vger.kernel.org, Dave Stevenson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com, Sergey Senozhatsky , Steven Rostedt , Jani Nikula Date: Fri, 03 Apr 2020 10:48:04 -0700 In-Reply-To: <20200403193242.38611906@coco.lan> References: <20200403091156.7814-1-sakari.ailus@linux.intel.com> <1105bfe5-88f1-040e-db40-54d7761747d5@rasmusvillemoes.dk> <20200403193242.38611906@coco.lan> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-04-03 at 19:32 +0200, Mauro Carvalho Chehab wrote: > Em Fri, 03 Apr 2020 09:56:42 -0700 > Joe Perches escreveu: [] > > How many instances of %p4cc could there be? > > That's hard to know... there are several places printing it > with different ways: > > $ git grep -i -E "(dev|pr)_(warn|dbg|info)" drivers/media|grep pixf|wc -l > 6 > $ git grep -i -E "print" drivers/media|grep pixf|wc -l > 1 > $ git grep print_fourcc|wc -l > 7 > $ git grep -i -E "(dev|pr)_(warn|dbg|info)" drivers/media|grep pixelf|wc -l > 10 > $ git grep -i -E "(dev|pr|v4l)_(warn|dbg|info)" drivers/media|grep format|wc -l > 60 > > I bet there are other places besides the above ones, but the thing is, as > we currently lack a standard way, drivers still have their own ideas > about how to handle it. Each one does it differently. My thought was ~100 uses was a minimum, rather like %pI6c. That's pretty close already, so I suppose that's enough. It _might_ be useful to use a CONFIG_MEDIA_SUPPORT guard in lib/vsprintf for this. cheers, Joe