From: Pavel Begunkov <asml.silence@gmail.com>
To: Olivier Langlois <olivier@trillion01.com>,
Jens Axboe <axboe@kernel.dk>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] io_uring: minor clean up in trace events definition
Date: Tue, 15 Jun 2021 10:48:54 +0100 [thread overview]
Message-ID: <2752dcc1-9e56-ba31-54ea-d2363ecb6c93@gmail.com> (raw)
In-Reply-To: <60be7e31.1c69fb81.a8bfb.2e54SMTPIN_ADDED_MISSING@mx.google.com>
On 5/31/21 7:54 AM, Olivier Langlois wrote:
> Fix tabulation to make nice columns
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
>
> Signed-off-by: Olivier Langlois <olivier@trillion01.com>
> ---
> include/trace/events/io_uring.h | 35 ++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 18 deletions(-)
>
> diff --git a/include/trace/events/io_uring.h b/include/trace/events/io_uring.h
> index 12addad1f837..e4e44a2b4aa9 100644
> --- a/include/trace/events/io_uring.h
> +++ b/include/trace/events/io_uring.h
> @@ -12,11 +12,11 @@ struct io_wq_work;
> /**
> * io_uring_create - called after a new io_uring context was prepared
> *
> - * @fd: corresponding file descriptor
> - * @ctx: pointer to a ring context structure
> + * @fd: corresponding file descriptor
> + * @ctx: pointer to a ring context structure
> * @sq_entries: actual SQ size
> * @cq_entries: actual CQ size
> - * @flags: SQ ring flags, provided to io_uring_setup(2)
> + * @flags: SQ ring flags, provided to io_uring_setup(2)
> *
> * Allows to trace io_uring creation and provide pointer to a context, that can
> * be used later to find correlated events.
> @@ -52,12 +52,12 @@ TRACE_EVENT(io_uring_create,
> * io_uring_register - called after a buffer/file/eventfd was successfully
> * registered for a ring
> *
> - * @ctx: pointer to a ring context structure
> - * @opcode: describes which operation to perform
> + * @ctx: pointer to a ring context structure
> + * @opcode: describes which operation to perform
> * @nr_user_files: number of registered files
> * @nr_user_bufs: number of registered buffers
> * @cq_ev_fd: whether eventfs registered or not
> - * @ret: return code
> + * @ret: return code
> *
> * Allows to trace fixed files/buffers/eventfds, that could be registered to
> * avoid an overhead of getting references to them for every operation. This
> @@ -142,16 +142,16 @@ TRACE_EVENT(io_uring_queue_async_work,
> TP_ARGS(ctx, rw, req, work, flags),
>
> TP_STRUCT__entry (
> - __field( void *, ctx )
> - __field( int, rw )
> - __field( void *, req )
> + __field( void *, ctx )
> + __field( int, rw )
> + __field( void *, req )
> __field( struct io_wq_work *, work )
> __field( unsigned int, flags )
> ),
>
> TP_fast_assign(
> __entry->ctx = ctx;
> - __entry->rw = rw;
> + __entry->rw = rw;
> __entry->req = req;
> __entry->work = work;
> __entry->flags = flags;
> @@ -196,10 +196,10 @@ TRACE_EVENT(io_uring_defer,
>
> /**
> * io_uring_link - called before the io_uring request added into link_list of
> - * another request
> + * another request
> *
> - * @ctx: pointer to a ring context structure
> - * @req: pointer to a linked request
> + * @ctx: pointer to a ring context structure
> + * @req: pointer to a linked request
> * @target_req: pointer to a previous request, that would contain @req
> *
> * Allows to track linked requests, to understand dependencies between requests
> @@ -212,8 +212,8 @@ TRACE_EVENT(io_uring_link,
> TP_ARGS(ctx, req, target_req),
>
> TP_STRUCT__entry (
> - __field( void *, ctx )
> - __field( void *, req )
> + __field( void *, ctx )
> + __field( void *, req )
> __field( void *, target_req )
> ),
>
> @@ -244,7 +244,7 @@ TRACE_EVENT(io_uring_cqring_wait,
> TP_ARGS(ctx, min_events),
>
> TP_STRUCT__entry (
> - __field( void *, ctx )
> + __field( void *, ctx )
> __field( int, min_events )
> ),
>
> @@ -272,7 +272,7 @@ TRACE_EVENT(io_uring_fail_link,
> TP_ARGS(req, link),
>
> TP_STRUCT__entry (
> - __field( void *, req )
> + __field( void *, req )
> __field( void *, link )
> ),
>
> @@ -318,7 +318,6 @@ TRACE_EVENT(io_uring_complete,
> __entry->res, __entry->cflags)
> );
>
> -
> /**
> * io_uring_submit_sqe - called before submitting one SQE
> *
>
--
Pavel Begunkov
next parent reply other threads:[~2021-06-15 9:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <60be7e31.1c69fb81.a8bfb.2e54SMTPIN_ADDED_MISSING@mx.google.com>
2021-06-15 9:48 ` Pavel Begunkov [this message]
2021-06-15 21:50 ` [PATCH v2 2/3] io_uring: minor clean up in trace events definition Jens Axboe
2021-06-15 23:35 ` Steven Rostedt
2021-06-16 12:49 ` Jens Axboe
2021-06-16 19:00 ` Olivier Langlois
2021-06-16 19:02 ` Jens Axboe
2021-06-16 21:30 ` Olivier Langlois
2021-06-16 21:33 ` Jens Axboe
2021-06-20 19:15 ` Olivier Langlois
2021-06-20 20:13 ` Pavel Begunkov
2021-06-16 13:33 ` Olivier Langlois
2021-06-16 13:43 ` Steven Rostedt
2021-06-16 13:53 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2752dcc1-9e56-ba31-54ea-d2363ecb6c93@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=olivier@trillion01.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).