From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754047AbcKRQ6E (ORCPT ); Fri, 18 Nov 2016 11:58:04 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:53510 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752526AbcKRQ6C (ORCPT ); Fri, 18 Nov 2016 11:58:02 -0500 From: Arnd Bergmann To: David Howells Cc: linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #2] Date: Fri, 18 Nov 2016 17:57:55 +0100 Message-ID: <2756474.23HNgnMOUG@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <147948603812.5122.5116851833739815967.stgit@warthog.procyon.org.uk> References: <147948603103.5122.1043337990092830185.stgit@warthog.procyon.org.uk> <147948603812.5122.5116851833739815967.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:F0A5KEybulMpCse0jdc1X5hg3QWfOl8F12jX0/UQ5d1jlVYYyCW 8y9ddeW6atcvY0TnH4CkXwdj1hwZpT9X2gp03DgifMIe0bV10HrToLT82GeEe2EGkKOCojI doCoka5W2J9zdGrShxWQ1DSO2nYbMY97h6JBOAbRl/62kvxIOizBOiovifp181WvEHeD9dY qs0fg7kULktFPmX/sIU6A== X-UI-Out-Filterresults: notjunk:1;V01:K0:67DeDNVpLkA=:VvsRNxStgU/D26hjouY7co tdn34F6ZJCBFfQ7K1yDinL/nfJQtPaJhuTpgdeowq9VijRSJSegJa/djwWcBaA6tB9hoAMsT+ 0MFY45LFt8EyQX0CzMmuCSceEilRcXIZbjzRsP9PG3IiFMW3WPZZ4N4XdDh567h8XpONXhGzS Si4IiH4zZuhOsZvIgVV8dW3wxbKChhIWoqaxFsg+ZDNpwwnvaRaBCGB4mK965HWz34SEOSX2z UqwHn7Jbv9qt054sIP1PPkmv//OJWsuRTrwdVy/r/vWnmoRi6ryCO5udkZ3PKoOHWUnZ//lc1 +GDswYt3rRdJ2ia2TBwN1xYaYUa1/bKhkSttk7tS3H/k6bNYLFqdpjVxtsGcxMgQw7Q/bL9Aq LhEEY/TxL59fqoInJLT3Ml80u2avlPnaVZiNF/GMipma3eClcU7dWvzOwKet1RMuZWEB6QpPf KMvafTt891QZNCoK6DoUsxXJcIK0S4yW0m8uv9pwPkzGrxdwOnGDpCI6lvZ4DV/V1AbVvEJt+ jOR8DDIqjFdc5KMRJBJtd2I8M7+44i8qFivBoZX32DsPVNH0cCinT/JCoZgrWIh7RfdK/48vV Y7APbNimlyW7kAG29gWRvsAtCxsXTX525fhlcqtOqFWObU8qHFHB440T7asQOEd1VB6YOJQXf 0m+GIiLmb+/vil+kxOjOf3FofKaxgJ1chO4i8LIRNbEthTLR4Ue2mScyg4i7xhGf8iiT02E1z d+jnoQxiNgwVe3R6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, November 18, 2016 4:20:38 PM CET David Howells wrote: > Add a system call to make extended file information available, including > file creation and some attribute flags where available through the > underlying filesystem. Looks great! Is there still hope of scheduling this for v4.10, or are you planning it for v4.11 at this point? > ======== > OVERVIEW > ======== > > The idea was initially proposed as a set of xattrs that could be retrieved > with getxattr(), but the general preferance proved to be for a new syscall > with an extended stat structure. > > This has a number of uses: ... > > Note that not all of the above are implemented here. It's good to have the whole list of possible features here, but the list of features that are actually implemented is probably more important for the changelog. You seem to have that list in the introductory mail but not in the actual patch. > - stat->atime = inode->i_atime; > > stat->mtime = inode->i_mtime; > stat->ctime = inode->i_ctime; > > - stat->blksize = (1 << inode->i_blkbits); > + stat->size = i_size_read(inode); > > stat->blocks = inode->i_blocks; > > -} > + stat->blksize = 1 << inode->i_blkbits; > > + stat->result_mask |= STATX_BASIC_STATS; > + if (IS_NOATIME(inode)) > + stat->result_mask &= ~STATX_ATIME; > + else > + stat->atime = inode->i_atime; This looks like you are changing the behavior of the existing stat call to no longer return the atime from the on-disk inode if NOATIME is set. Is my interpretation correct, and is this an intentional change? Arnd