linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: mingo@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Mutex compilation error
Date: Tue, 10 Jan 2006 14:19:27 +0000	[thread overview]
Message-ID: <2758.1136902767@warthog.cambridge.redhat.com> (raw)


Hi Ingo,

I've found a compilation error in mutexes when using the null variety:

	In file included from kernel/mutex-debug.c:25:
	kernel/mutex-debug.h:23:1: warning: "__IP__" redefined
	In file included from include/asm/mutex.h:9,
			 from kernel/mutex-debug.c:23:
	include/asm-generic/mutex-null.h:15:1: warning: this is the location of the previous definition

It seems that mutex-null.h defined __IP__ before mutex-debug.h because in
mutex-debug.c:

	#include <asm/mutex.h>

	#include "mutex-debug.h"

is the ordering of the includes.

Whilst mutex-null.h defends against multiple inclusions of __IP__,
mutex-debug.h does not.

David

             reply	other threads:[~2006-01-10 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-10 14:19 David Howells [this message]
2006-01-10 20:48 ` [patch] remove unnecessary asm/mutex.h from kernel/mutex-debug.c Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2758.1136902767@warthog.cambridge.redhat.com \
    --to=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).