From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753534AbcD1UpV (ORCPT ); Thu, 28 Apr 2016 16:45:21 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:63080 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753417AbcD1UpP (ORCPT ); Thu, 28 Apr 2016 16:45:15 -0400 From: Arnd Bergmann To: Yury Norov Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, broonie@kernel.org, linux-doc@vger.kernel.org, heiko.carstens@de.ibm.com, agraf@suse.de, klimov.linux@gmail.com, Andrew Pinski , bamvor.zhangjian@huawei.com, Andrew Pinski , schwidefsky@de.ibm.com, Nathan_Lynch@mentor.com, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Date: Thu, 28 Apr 2016 22:43:59 +0200 Message-ID: <2760348.qmm1L3yQch@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160428191914.GA28527@yury-N73SV> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <20160426165701.GE8525@e104818-lin.cambridge.arm.com> <20160428191914.GA28527@yury-N73SV> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:vrxV8OZWXXqzI8a4tnanIUsWo2Cd33tAINTR53lftqJ4/+jfiXi CZ4ZJfkJp/6eQ+1sWxy072HKrX2swIQZgd1TnmfRyxglVbub7tWNwXsMvvaAA3kKjrglyLi aoPlp5H63eNwnrjAfzNOzEPhjSSqWD13O3aIpImlmf1YJr3/wHpaZTwI/X/Vd+2Gim+P7/3 FcBADD8d/RQLfIqcH1Mrg== X-UI-Out-Filterresults: notjunk:1;V01:K0:i2pFnKxWFR4=:oUStY9KulxHVHHKApe1LP8 An5AEpH4lSCl8psle2Omf/j6KodOaoROEfMPGeB8qDEPZR5Sx2zLyOc3Zh32fc14dW0tpaDM0 vjpoVeQCu7fRHT/J+F8sZ5WDyNQ77Tf0aiD5GKcHJth0JVVEPU/m3f+v+qydER1u3HiHo1wW0 VdB893JlbN10299slXRvyBulZCgy8pY2qfB6ITqGeeWImyHgZ61lBibQMhaDp9GfkrbL275F7 Bbia/B8bKTZUkw4Tuttnya0p+rIgVL+s0ns63umZ9O3PaCck4fexniflqaMP/uQcaFaO9Yp2O lDh5a7/j/QMmXmEgIwx24Dbqcey04nEUhnTyAaYnQ1s19bQG7Q4qNvyxWtyUD9gOLI4P3VDmo W8LH0uzeQxnm7bEpYD4E0/DS+EI6HkPv0ilAAtCSUJCNYJ/dj/SsK3QJ+EA9tjGQeN9DMHqUH yWCjcl4XBonOmj80/9/BDtvRhn8PBRCIDWvpV8tSuEr8T3JdgEG9jHzXF5WQxUHSX/r9KP0uZ 6edIkQ0YBfUl4/QixsqmlNRkdth1NWMEna5as/QTYaFm6D/qvV+dUT5lkfQcGUsK28itHfT6s siKI6/+8+g6T6IreTEBtZEr4zqqaetlDRbL/83YM6M1e1JOiv2MHVDiPlwtnwozQTLCiWqWrz 1CPuG/+HuDeVkTWoLYAqQB4fLKWmcaa2ViuT2KDG0ZeO+7FCLPzR4JTsazBtw74a8jHzGn1+W kMcgsUvUMjKLGNWD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 28 April 2016 22:19:14 Yury Norov wrote: > > Yes, we need. Otherwise we have circular dependency like this: > arch/arm64/kernel/sys_ilp32.c:60:0: warning: "__SC_WRAP" redefined > #define __SC_WRAP(nr, sym) [nr] = compat_##sym, > ^ > In file included from include/asm-generic/unistd.h:1:0, > from ./arch/arm64/include/uapi/asm/unistd.h:16, > from ./arch/arm64/include/asm/unistd.h:62, > from ./include/uapi/linux/unistd.h:7, > from include/linux/syscalls.h:23, > from arch/arm64/kernel/sys_ilp32.c:30: > include/uapi/asm-generic/unistd.h:33:0: note: this is the location of the previous definition > #define __SC_WRAP __SYSCALL > > Defining __SYSCALL_COMPAT at the top of the file does not help much. Hmm, this sounds like something that we should fix in the asm-generic/unistd.h file. Is it just for __SC_WRAP, or also the other macros? Arnd