* [PATCH] firmware_loader: Remove unnecessary conversion to bool
@ 2021-02-18 9:12 Jiapeng Chong
2021-04-02 22:24 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-02-18 9:12 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./tools/testing/selftests/firmware/fw_namespace.c:98:54-59: WARNING:
conversion to bool not needed here.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
tools/testing/selftests/firmware/fw_namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/firmware/fw_namespace.c b/tools/testing/selftests/firmware/fw_namespace.c
index 5ebc1ae..0e393cb 100644
--- a/tools/testing/selftests/firmware/fw_namespace.c
+++ b/tools/testing/selftests/firmware/fw_namespace.c
@@ -95,7 +95,7 @@ static bool test_fw_in_ns(const char *fw_name, const char *sys_path, bool block_
}
if (block_fw_in_parent_ns)
umount("/lib/firmware");
- return WEXITSTATUS(status) == EXIT_SUCCESS ? true : false;
+ return WEXITSTATUS(status) == EXIT_SUCCESS;
}
if (unshare(CLONE_NEWNS) != 0) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware_loader: Remove unnecessary conversion to bool
2021-02-18 9:12 [PATCH] firmware_loader: Remove unnecessary conversion to bool Jiapeng Chong
@ 2021-04-02 22:24 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2021-04-02 22:24 UTC (permalink / raw)
To: Jiapeng Chong, shuah; +Cc: linux-kselftest, linux-kernel, Shuah Khan
On 2/18/21 2:12 AM, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./tools/testing/selftests/firmware/fw_namespace.c:98:54-59: WARNING:
> conversion to bool not needed here.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> tools/testing/selftests/firmware/fw_namespace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/firmware/fw_namespace.c b/tools/testing/selftests/firmware/fw_namespace.c
> index 5ebc1ae..0e393cb 100644
> --- a/tools/testing/selftests/firmware/fw_namespace.c
> +++ b/tools/testing/selftests/firmware/fw_namespace.c
> @@ -95,7 +95,7 @@ static bool test_fw_in_ns(const char *fw_name, const char *sys_path, bool block_
> }
> if (block_fw_in_parent_ns)
> umount("/lib/firmware");
> - return WEXITSTATUS(status) == EXIT_SUCCESS ? true : false;
This looks right to me. test_fw_in_ns() returns true or false and
test_fw_in_ns() callers print appropriate message.
I don't think this patch is necessary.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-02 22:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 9:12 [PATCH] firmware_loader: Remove unnecessary conversion to bool Jiapeng Chong
2021-04-02 22:24 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).