From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 636DBC433F5 for ; Wed, 30 Mar 2022 12:20:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345773AbiC3MWD (ORCPT ); Wed, 30 Mar 2022 08:22:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345300AbiC3MNk (ORCPT ); Wed, 30 Mar 2022 08:13:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B61D649F88 for ; Wed, 30 Mar 2022 05:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648642039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p4IaRvBma0W1UBcawEsDhyvvua/6JtF1rikRuXR/v3o=; b=UDcjrvDDA2M6JJCbmKRAOORM4sC1G7oRuzEzy9UrOgvf5Fa8t+2Zl82yiAuNjJS64+T0NE jjrLrz6n/HjZjwQX5IeaE0Fx/GPZku+xOdvNOPeuoN/N0kyZ6CUotbcfeBKhI+6xg31y3R cjpQwPFNEOPkvDAzO5yzKvh15nQe4b0= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-208-we63gjnkPYGBi9CXAT6kJg-1; Wed, 30 Mar 2022 08:07:17 -0400 X-MC-Unique: we63gjnkPYGBi9CXAT6kJg-1 Received: by mail-ed1-f72.google.com with SMTP id u17-20020a05640207d100b00418f00014f8so7586450edy.18 for ; Wed, 30 Mar 2022 05:07:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=p4IaRvBma0W1UBcawEsDhyvvua/6JtF1rikRuXR/v3o=; b=ru23hg43jrYJxouk+o77QTnJuLtvg9lxyhx2lrfhbvSnNlBJ7J9q5t1PU+DcaqO0/R 2TyxIHHvr4C9goKpqJu3u2wNcs/jOLdetghMxTlUXENfHhqrgl4SV0bNrs9tTz6G2rin B7bE750wBOwfqciokJtCvZm8dJ9zmyXAkAmGaIbgIiyeAUCPmugo2OhDSncyMJD2ZfxW sHbJVf1LYZjfza4s9gVbCtILCTuqhIsM86sQZYmcUzNaG7BM1CPJw19S0tPJ43+Y5UxH bA0N+eBQnK7RbmXk0gtasAGGlI3eWtp9m9L8O8pSrtG5w/kWA3Hzj/CTnj2wWd/g/1Mj pPQA== X-Gm-Message-State: AOAM530d/md83md/TRbeZCaXoVckLNOp0qt0Kqv7N2t2r1C/r+8Z6cAI sacryWHWw8md2w45Sv8EGzgLAS+im1/umy56qbY6zxFgTjuwuaV3eXh/6kW9IPJy9moAARTXNEH vOlCCqzo0t+ovRSPkSf0S0q9R X-Received: by 2002:a17:907:629a:b0:6d7:b33e:43f4 with SMTP id nd26-20020a170907629a00b006d7b33e43f4mr40595894ejc.149.1648642034594; Wed, 30 Mar 2022 05:07:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzStAnN2iHa+Rqbu8eIJhXelGfz14EyM1yta1FQP72irc8UflbROtPx9mfIOIWwkGT4QHJKyw== X-Received: by 2002:a17:907:629a:b0:6d7:b33e:43f4 with SMTP id nd26-20020a170907629a00b006d7b33e43f4mr40595860ejc.149.1648642034371; Wed, 30 Mar 2022 05:07:14 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:8ca6:a836:a237:fed1? ([2001:b07:6468:f312:8ca6:a836:a237:fed1]) by smtp.googlemail.com with ESMTPSA id v2-20020a17090606c200b006a728f4a9bcsm8235476ejb.148.2022.03.30.05.07.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 05:07:13 -0700 (PDT) Message-ID: <27670a35-c67e-726f-f03f-9cf2eae83523@redhat.com> Date: Wed, 30 Mar 2022 14:07:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 1/8] KVM: x86: avoid loading a vCPU after .vm_destroy was called Content-Language: en-US To: Sean Christopherson , Maxim Levitsky Cc: kvm@vger.kernel.org, Jim Mattson , Wanpeng Li , Borislav Petkov , Joerg Roedel , Ingo Molnar , Suravee Suthikulpanit , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , linux-kernel@vger.kernel.org, Vitaly Kuznetsov , Thomas Gleixner , stable@vger.kernel.org References: <20220322172449.235575-1-mlevitsk@redhat.com> <20220322172449.235575-2-mlevitsk@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/30/22 02:27, Sean Christopherson wrote: > Rather than split kvm_free_vcpus(), can we instead move the call to svm_vm_destroy() > by adding a second hook, .vm_teardown(), which is needed for TDX? I.e. keep VMX > where it is by using vm_teardown, but effectively move SVM? > > https://lore.kernel.org/all/1fa2d0db387a99352d44247728c5b8ae5f5cab4d.1637799475.git.isaku.yamahata@intel.com I'd rather do that only for the TDX patches. Paolo