From: Sven Eckelmann <sven@narfation.org>
To: cgel.zte@gmail.com
Cc: a@unstable.cc, b.a.t.m.a.n@lists.open-mesh.org,
cgel.zte@gmail.com, chi.minghao@zte.com.cn, davem@davemloft.net,
kuba@kernel.org, linux-kernel@vger.kernel.org,
mareklindner@neomailbox.ch, netdev@vger.kernel.org,
sw@simonwunderlich.de, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCHv2] net/batman-adv:remove unneeded variable
Date: Fri, 10 Dec 2021 10:51:44 +0100 [thread overview]
Message-ID: <2776551.YYyxiJnSHr@ripper> (raw)
In-Reply-To: <20211210094206.426283-1-chi.minghao@zte.com.cn>
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
On Friday, 10 December 2021 10:42:06 CET cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return status directly from function called.
> change since v1: zealci@zte.com.cm
> v2: zealci@zte.com.cn
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
This is wrong:
1. the patch was already applied
2. the patch history doesn't belong in the commit message
3. there is still an alignment problem
4. if you use -v in git-format-patch then it should be "PATCH v2" and not
"PATCHv2" (otherwise it will not be parsed correctly by patchwork)
5. The alignment problem is still there
6. the subject is also not following the normal formatting style
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-12-10 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 2:19 [PATCH] net/batman-adv:remove unneeded variable cgel.zte
2021-12-10 7:49 ` Sven Eckelmann
2021-12-10 7:52 ` Sven Eckelmann
2021-12-10 9:42 ` [PATCHv2] " cgel.zte
2021-12-10 9:51 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2776551.YYyxiJnSHr@ripper \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=sw@simonwunderlich.de \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).