From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753518AbdEQJBU (ORCPT ); Wed, 17 May 2017 05:01:20 -0400 Received: from gloria.sntech.de ([95.129.55.99]:44456 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753348AbdEQJBQ (ORCPT ); Wed, 17 May 2017 05:01:16 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Frank Wang Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, charles.chen@rock-chips.com, cody.xie@rock-chips.com, kevan.lan@rock-chips.com, huangtao@rock-chips.com, sugar.zhang@rock-chips.com, wmc@rock-chips.com Subject: Re: [PATCH 1/3] arm: dts: rk322x: fix i2s1 pinctrl error Date: Wed, 17 May 2017 11:01:00 +0200 Message-ID: <2781249.GNsgFIKA50@diego> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <1494992451-32542-2-git-send-email-frank.wang@rock-chips.com> References: <1494992451-32542-1-git-send-email-frank.wang@rock-chips.com> <1494992451-32542-2-git-send-email-frank.wang@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Frank, Am Mittwoch, 17. Mai 2017, 11:40:49 CEST schrieb Frank Wang: > From: Sugar Zhang > > Refer to Chapter 5.3.2 of rk3229 TRM, we can see that GPIO1A[2,4,5] > using RK_FUNC_2 not RK_FUNC_1. This patch fixes it. > > Signed-off-by: Frank Wang if the patch has another author, you should preserve his/her Signed-off-by line, so for example this patch would look like: Signed-off-by: Sugar Zhang Signed-off-by: Frank Wang Same for all other patches with differing authors in your 2 series from today. As this touches the developer-certificate-of-origin, this is also something I cannot really correct myself. Heiko > --- > arch/arm/boot/dts/rk322x.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi > index 48a0c1c..cc6a27d 100644 > --- a/arch/arm/boot/dts/rk322x.dtsi > +++ b/arch/arm/boot/dts/rk322x.dtsi > @@ -621,9 +621,9 @@ > <0 12 RK_FUNC_1 &pcfg_pull_none>, > <0 13 RK_FUNC_1 &pcfg_pull_none>, > <0 14 RK_FUNC_1 &pcfg_pull_none>, > - <1 2 RK_FUNC_1 &pcfg_pull_none>, > - <1 4 RK_FUNC_1 &pcfg_pull_none>, > - <1 5 RK_FUNC_1 &pcfg_pull_none>; > + <1 2 RK_FUNC_2 &pcfg_pull_none>, > + <1 4 RK_FUNC_2 &pcfg_pull_none>, > + <1 5 RK_FUNC_2 &pcfg_pull_none>; > }; > };