From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942729AbcJ0OrQ convert rfc822-to-8bit (ORCPT ); Thu, 27 Oct 2016 10:47:16 -0400 Received: from li42-95.members.linode.com ([209.123.162.95]:52134 "EHLO li42-95.members.linode.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755953AbcJ0OrN (ORCPT ); Thu, 27 Oct 2016 10:47:13 -0400 X-Greylist: delayed 354 seconds by postgrey-1.27 at vger.kernel.org; Thu, 27 Oct 2016 10:47:13 EDT Subject: Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=utf-8 From: Pantelis Antoniou In-Reply-To: <1477429146-27039-14-git-send-email-frowand.list@gmail.com> Date: Thu, 27 Oct 2016 17:41:54 +0300 Cc: Rob Herring , devicetree , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <27823D48-C6B1-486C-8460-9B3C33DDC62F@antoniou-consulting.com> References: <1477429146-27039-1-git-send-email-frowand.list@gmail.com> <1477429146-27039-14-git-send-email-frowand.list@gmail.com> To: frowand.list@gmail.com X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Frank, > On Oct 25, 2016, at 23:59 , frowand.list@gmail.com wrote: > > From: Frank Rowand > > This unused variable is a reminder that symbols in overlays are > not available to subsequent overlays. If such a feature is > desired then there are several ways it could be implemented. > Please don’t apply that. There’s a patch that actually imports the symbol table from overlays that subsequent operations work. Please see: https://patchwork.kernel.org/patch/9104701/ > Signed-off-by: Frank Rowand > --- > drivers/of/resolver.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c > index 3f7cf569c7ea..b48d16200ccd 100644 > --- a/drivers/of/resolver.c > +++ b/drivers/of/resolver.c > @@ -272,7 +272,7 @@ static int adjust_local_phandle_references(struct device_node *local_fixups, > int of_resolve_phandles(struct device_node *overlay) > { > struct device_node *child, *local_fixups, *refnode; > - struct device_node *tree_symbols, *overlay_symbols, *overlay_fixups; > + struct device_node *tree_symbols, *overlay_fixups; > struct property *prop; > const char *refpath; > phandle phandle, phandle_delta; > @@ -302,12 +302,9 @@ int of_resolve_phandles(struct device_node *overlay) > if (err) > goto err_out; > > - overlay_symbols = NULL; > overlay_fixups = NULL; > > for_each_child_of_node(overlay, child) { > - if (!of_node_cmp(child->name, "__symbols__")) > - overlay_symbols = child; > if (!of_node_cmp(child->name, "__fixups__")) > overlay_fixups = child; > } > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Regards — Pantelis