From: Heiko Stuebner <heiko@sntech.de>
To: Elaine Zhang <zhangqing@rock-chips.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, rjw@rjwysocki.net,
khilman@kernel.org, ulf.hansson@linaro.org,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
wxt@rock-chips.com, xxx@rock-chips.com, xf@rock-chips.com,
huangtao@rock-chips.com, Finley Xiao <finley.xiao@rock-chips.com>
Subject: Re: [PATCH v1 04/13] soc: rockchip: power-domain: Fix wrong value when power up pd
Date: Sat, 12 May 2018 16:11:00 +0200 [thread overview]
Message-ID: <2785491.5jVj6F0Ubh@phil> (raw)
In-Reply-To: <1526009458-28579-5-git-send-email-zhangqing@rock-chips.com>
Hi Elaine,
Am Freitag, 11. Mai 2018, 05:30:49 CEST schrieb Elaine Zhang:
please provide a patch description. This seems to affect rk3328
alone right now, but seems that rk3328 could only ever turn off
power-domains but never turn them on again, right?
Authorship comment from my previous comment applies here
as well.
And please add a
Fixes: 9bb17ce8edb3 ("soc: rockchip: power-domain: Support domain control in hiword-registers")
Cc: stable@vger.kernel.org
to the patch description.
Thanks
Heiko
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> ---
> drivers/soc/rockchip/pm_domains.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/rockchip/pm_domains.c b/drivers/soc/rockchip/pm_domains.c
> index ebd7c41898c0..01d4ba26a054 100644
> --- a/drivers/soc/rockchip/pm_domains.c
> +++ b/drivers/soc/rockchip/pm_domains.c
> @@ -264,7 +264,7 @@ static void rockchip_do_pmu_set_power_domain(struct rockchip_pm_domain *pd,
> return;
> else if (pd->info->pwr_w_mask)
> regmap_write(pmu->regmap, pmu->info->pwr_offset,
> - on ? pd->info->pwr_mask :
> + on ? pd->info->pwr_w_mask :
> (pd->info->pwr_mask | pd->info->pwr_w_mask));
> else
> regmap_update_bits(pmu->regmap, pmu->info->pwr_offset,
>
next prev parent reply other threads:[~2018-05-12 14:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 3:30 [PATCH v1 00/13] add power domain support for Rockchip Socs Elaine Zhang
2018-05-11 3:30 ` [PATCH v1 01/13] dt-bindings: power: add RK3036 SoCs header for power-domain Elaine Zhang
2018-05-11 3:30 ` [PATCH v1 02/13] dt-bindings: add binding for rk3036 power domains Elaine Zhang
2018-05-11 3:30 ` [PATCH v1 03/13] Soc: rockchip: power-domain: add power domain support for rk3036 Elaine Zhang
2018-05-11 3:30 ` [PATCH v1 04/13] soc: rockchip: power-domain: Fix wrong value when power up pd Elaine Zhang
2018-05-12 14:11 ` Heiko Stuebner [this message]
2018-05-11 3:32 ` [PATCH v1 05/13] dt-bindings: power: add RK3128 SoCs header for power-domain Elaine Zhang
2018-05-11 3:32 ` [PATCH v1 06/13] dt-bindings: add binding for rk3128 power domains Elaine Zhang
2018-05-11 3:33 ` [PATCH v1 07/13] soc: rockchip: power-domain: add power domain support for rk3128 Elaine Zhang
2018-05-11 3:33 ` [PATCH v1 08/13] dt-bindings: power: add RK3228 SoCs header for power-domain Elaine Zhang
2018-05-11 3:33 ` [PATCH v1 09/13] dt-bindings: add binding for rk3228 power domains Elaine Zhang
2018-05-11 3:34 ` [PATCH v1 10/13] soc: rockchip: power-domain: add power domain support for rk3228 Elaine Zhang
2018-05-11 3:34 ` [PATCH v1 11/13] dt-bindings: power: add PX30 SoCs header for power-domain Elaine Zhang
2018-05-11 22:11 ` Heiko Stuebner
2018-05-13 15:18 ` Tao Huang
2018-05-13 20:53 ` Heiko Stübner
2018-05-11 3:34 ` [PATCH v1 12/13] dt-bindings: add binding for px30 power domains Elaine Zhang
2018-05-11 3:35 ` [PATCH v1 13/13] soc: rockchip: power-domain: add power domain support for px30 Elaine Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2785491.5jVj6F0Ubh@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=finley.xiao@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wxt@rock-chips.com \
--cc=xf@rock-chips.com \
--cc=xxx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).