From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: catalin.marinas@arm.com, will@kernel.org,
mike.kravetz@oracle.com, akpm@linux-foundation.org,
willy@infradead.org, anshuman.khandual@arm.com,
christophe.leroy@csgroup.eu,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page
Date: Wed, 11 May 2022 09:24:09 +0800 [thread overview]
Message-ID: <278d1d30-a7ad-11df-5242-5472a841a3b3@linux.alibaba.com> (raw)
In-Reply-To: <YnqK+Hah0wzMvT1p@FVFYT0MHHV2J.usts.net>
On 5/10/2022 11:55 PM, Muchun Song wrote:
> On Tue, May 10, 2022 at 07:12:52PM +0800, Baolin Wang wrote:
>> The original huge_ptep_get() on ARM64 is just a wrapper of ptep_get(),
>> which will not take into account any contig-PTEs dirty and access bits.
>> Meanwhile we will implement a new ARM64-specific huge_ptep_get()
>> interface in following patch, which will take into account any contig-PTEs
>> dirty and access bits and only be allowed to pass the head pte of
>> a contig-PTE/PMD size page.
>
> IIUC, the huge_ptep_get() you have implemented in patch 2 could
> handle non-head pte. It'll return the original pte without potential
> AD bit. I admit it is more efficeent to use ptep_get() directly,
> but the judgement here should be updated.
Ah, right. I missed the 'ncontig' will be 0 if a non-head pte passed.
Will update the commit message in next version. Thanks for reviewing.
>
> With this update.
>
> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
next prev parent reply other threads:[~2022-05-11 1:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 11:12 [PATCH 0/2] Implement arm64 specific huge_ptep_get() Baolin Wang
2022-05-10 11:12 ` [PATCH 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page Baolin Wang
2022-05-10 15:55 ` Muchun Song
2022-05-11 1:24 ` Baolin Wang [this message]
2022-05-10 11:12 ` [PATCH 2/2] arm64/hugetlb: Implement arm64 specific huge_ptep_get() Baolin Wang
2022-05-10 15:59 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=278d1d30-a7ad-11df-5242-5472a841a3b3@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).