From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C48EC433FE for ; Sat, 4 Sep 2021 20:46:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5DAE60F45 for ; Sat, 4 Sep 2021 20:46:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233573AbhIDUms (ORCPT ); Sat, 4 Sep 2021 16:42:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229888AbhIDUmr (ORCPT ); Sat, 4 Sep 2021 16:42:47 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 880A4C061575 for ; Sat, 4 Sep 2021 13:41:45 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id i21so5157211ejd.2 for ; Sat, 04 Sep 2021 13:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lFrmrzYdi4W9e05rZQyIefjI/ECSxbcxYQllGrHvMCg=; b=B0Z6m3EEkmYaeB0NxXr0zIH17/0/9gVvynrZc4f+uYbPozTISUs3B1mPr7AwYYAQr8 Q3jBlroT+bOU+6l4FcfgYkd98mmA6FLmJ4TtHL5Q3rDX7bc9Rtrdd9Ud3td7ng8Eg6bk ZLc0EAOQoEWqhEodV+9A3Kclx79CkCVz3KUTsZW7kAF5OLY/NmaD9L3YSACuz2P1Nhll bwVvWUekDrsHG28XHdG9aFzA1OCGAQcGphVcSSiToXI5QWYui/tUe+Wkg3UM2kMXK7ad p//z9SKxYx99GHV8HUwJ2H8rKsD/nDqWmNWz1X+7PLXEmsi7iwv1t3d5yb+5UtKaS7Ng Lezw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lFrmrzYdi4W9e05rZQyIefjI/ECSxbcxYQllGrHvMCg=; b=hyxQhJSa19DClBsLIWJpUt38sVZFIHrQXxSj+K0loBJDvsWAEJMscb9KKZ/XFqBV/C ImyazfszlsMS2JduQikVjAiV84sU8ESce3L94aiOcHA7u3wbSuDfTg4IWuAflrpf6fSz p7m5Cb7njMCeVLxh01gFogDgf9jvjy8XvVqCaEnknNv4+liA03xi6npQTkRia1wo4CxS T/PbZdMBnv0LmCEIFUduYHSn5nsfwPchRMGQg3cdtBj+nZV+piIW3Q6ouG26UeZoMDTd OqNGiju/FMVJrBkkgUagz8PNHG1FKes9hZrioVCr/dkbV5zeAkVYoeeOHi047zdcwFuV wHEg== X-Gm-Message-State: AOAM532bWwCBD5329PhsW+Kjzj+mKCAZf0fJFEnOH15ybYV2NVFJTrj6 cmOI17B1rBXPWqX5C4hUNyo= X-Google-Smtp-Source: ABdhPJxiSqnDZgkoMQ1RWDgSU3bxKLT9uacc3Q13nxfYCAaGFQxz88qrVNX+8deihPMXKkFfeHoA4w== X-Received: by 2002:a17:906:3fc1:: with SMTP id k1mr5824741ejj.44.1630788103998; Sat, 04 Sep 2021 13:41:43 -0700 (PDT) Received: from localhost.localdomain (host-79-23-101-208.retail.telecomitalia.it. [79.23.101.208]) by smtp.gmail.com with ESMTPSA id n2sm1854806edi.32.2021.09.04.13.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Sep 2021 13:41:43 -0700 (PDT) From: "Fabio M. De Francesco" To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , Pavel Skripkin Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel test robot , kbuild-all@lists.01.org Subject: Re: [PATCH 3/3] staging: r8188eu: Shorten calls chain of rtw_write8/16/32/N() Date: Sat, 04 Sep 2021 22:41:41 +0200 Message-ID: <2791328.7pjKATJfGa@localhost.localdomain> In-Reply-To: <202109050113.Uyg2SCTW-lkp@intel.com> References: <20210904150447.14659-4-fmdefrancesco@gmail.com> <202109050113.Uyg2SCTW-lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="ISO-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 4, 2021 7:09:58 PM CEST kernel test robot wrote: > Hi "Fabio, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on staging/staging-testing] > > url: https://github.com/0day-ci/linux/commits/Fabio-M-De-Francesco/ staging-r8188eu-Shorten-and-simplify-calls-chain/20210904-231010 > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git fde4862d1ac7100028da4371d92454fec6cf3f4f > > [...] > > All errors (new ones prefixed by >>): > > drivers/staging/r8188eu/hal/usb_ops_linux.c: In function 'usb_write': > >> drivers/staging/r8188eu/hal/usb_ops_linux.c:105:47: error: 'REALTEK_USB_VENQT_SEND' undeclared (first use in this function); did you mean 'REALTEK_USB_VENQT_READ'? > 105 | REALTEK_USB_VENQT_SEND, value, > | ^~~~~~~~~~~~~~~~~~~~~~ > Hello to all, I apologize for this easily avoidable mistake. I'm about to post the v2 series. However, I write this message to affirm that Pavel's tests on this patch are still valid and confirmed because his copy *has* the right parameter that is REALTEK_USB_VENQT_WRITE. It's all my fault. Pavel warned me that during the review and test he noticed that I had written REALTEK_USB_VENQT_READ and obviously my build was successful because it was a symbol known to the compiler. Pavel successfully changed his local copy and I (independently) changed mine without thinking about rebuilding. I was absolutely certain it was the expected parameter (perhaps the function name - usb_control_msg_send () - played a part in leading me to this stupid mistake). In summary, first I want to apologize for the noise, secondly I want to apologize to Pavel who is co-author and tester of this 3/3 of our series. Regards, Fabio