From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 588CCC433DB for ; Fri, 5 Feb 2021 03:13:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0159F64FB7 for ; Fri, 5 Feb 2021 03:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbhBEDNE (ORCPT ); Thu, 4 Feb 2021 22:13:04 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12464 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbhBEDM7 (ORCPT ); Thu, 4 Feb 2021 22:12:59 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DX0mf3pmMzjK9y; Fri, 5 Feb 2021 11:10:58 +0800 (CST) Received: from [10.174.179.241] (10.174.179.241) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Fri, 5 Feb 2021 11:12:13 +0800 Subject: Re: [PATCH] mm/rmap: Correct obsolete comment of page_get_anon_vma() To: Matthew Wilcox CC: , , References: <20210203093215.31990-1-linmiaohe@huawei.com> <20210204123807.GE308988@casper.infradead.org> From: Miaohe Lin Message-ID: <27b33f18-7c5e-8b0a-abea-f4eef01e6285@huawei.com> Date: Fri, 5 Feb 2021 11:11:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210204123807.GE308988@casper.infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.241] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi: On 2021/2/4 20:38, Matthew Wilcox wrote: > On Wed, Feb 03, 2021 at 04:32:15AM -0500, Miaohe Lin wrote: >> * Since there is no serialization what so ever against page_remove_rmap() >> - * the best this function can do is return a locked anon_vma that might >> - * have been relevant to this page. >> + * the best this function can do is return a refcount increased anon_vma >> + * that might have been relevant to this page. > > Just s/a locked/an/ Many thanks for your review and reply. > there's no need to mention again that the refcount> is increased. I think it's ok to mention again that the refcount is increased although I didn't find out where this is first mentioned. Thanks again. > . >