From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC00C433FE for ; Tue, 7 Sep 2021 08:00:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8225610C8 for ; Tue, 7 Sep 2021 08:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241634AbhIGIBu (ORCPT ); Tue, 7 Sep 2021 04:01:50 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:39262 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S231366AbhIGIBs (ORCPT ); Tue, 7 Sep 2021 04:01:48 -0400 X-UUID: 289a8e123b5d49daab79ec2ce6a8031d-20210907 X-UUID: 289a8e123b5d49daab79ec2ce6a8031d-20210907 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 312245765; Tue, 07 Sep 2021 16:00:39 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 16:00:37 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkcas07.mediatek.inc (172.21.101.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 16:00:37 +0800 Received: from mtksdccf07 (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 7 Sep 2021 16:00:37 +0800 Message-ID: <27ca1a1e99193b543102df03f7c256063468f693.camel@mediatek.com> Subject: Re: [PATCH] ASoC: mediatek: mt8195: Fix unused initialization of pointer etdm_data From: Trevor Wu To: Colin King , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , , , CC: , Date: Tue, 7 Sep 2021 16:00:37 +0800 In-Reply-To: <20210903114928.11743-1-colin.king@canonical.com> References: <20210903114928.11743-1-colin.king@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-09-03 at 12:49 +0100, Colin King wrote: > From: Colin Ian King > > The pointer etdm_data is being inintialized with a value that is > never > read, it is later being re-assigned a new value. Remove the redundant > initialization. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > index 7378e42f2766..ac591d453e1e 100644 > --- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > +++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > @@ -2094,7 +2094,7 @@ static int mtk_dai_etdm_set_sysclk(struct > snd_soc_dai *dai, > { > struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); > struct mt8195_afe_private *afe_priv = afe->platform_priv; > - struct mtk_dai_etdm_priv *etdm_data = afe_priv->dai_priv[dai- > >id]; > + struct mtk_dai_etdm_priv *etdm_data; > int dai_id; > > dev_dbg(dai->dev, "%s id %d freq %u, dir %d\n", Acked-by: Trevor Wu Thanks.