From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Li-hao Kuo <lhjeff911@gmail.com>,
rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org,
rui.zhang@intel.com, robh+dt@kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: lh.kuo@sunplus.com
Subject: Re: [PATCH v10 2/2] dt-bindings: thermal: Add Sunplus schema
Date: Wed, 13 Jul 2022 09:50:47 +0200 [thread overview]
Message-ID: <27cd6e98-50c6-14b2-aec0-b4bbd49a9da8@linaro.org> (raw)
In-Reply-To: <5d2c95959dd6efaa204bc80ca9b24a8be9293d2f.1654660009.git.lhjeff911@gmail.com>
On 12/07/2022 09:30, Li-hao Kuo wrote:
> Add bindings for Sunplus thermal driver
>
> Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
> ---
> Changes in v10:
> - Fix wrong indentation.
> - Change the setting of compatible.
> - Mosdify the setting of remove funciton.
>
> .../bindings/thermal/sunplus,thermal.yaml | 43 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml
>
> diff --git a/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml b/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml
> new file mode 100644
> index 0000000..52094da
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/sunplus,thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus Thermal controller
> +
> +maintainers:
> + - Li-hao Kuo <lhjeff911@gmail.com>
> +
> +properties:
> + compatible:
> + enum:
> + - sunplus,sp7021-thermal
> +
> + reg:
> + maxItems: 1
> +
> + nvmem-cells:
> + maxItems: 1
> +
> + nvmem-cell-names:
> + const: calib
> +
> +required:
> + - compatible
> + - reg
> + - nvmem-cells
> + - nvmem-cell-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + thermal@9c000280 {
> + compatible = "sunplus,sp7021-thermal";
> + reg = <0x9c000280 0xc>;
> + nvmem-cells = <&calib>;
> + nvmem-cell-names = "calib";
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 23bde07..a8c44eb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19107,6 +19107,7 @@ SUNPLUS THERMAL DRIVER
> M: Li-hao Kuo <lhjeff911@gmail.com>
> L: linux-pm@vger.kernel.org
> S: Maintained
> +F: Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
Not a correct path anymore.
Around v7 I asked to name the file either sunplus,thermal.yaml or
sunplus,sp7021-thermal.yaml, but actually that was my mistake a bit
which I learnt later. The only recommended name is the latter, based on
compatible, so:
sunplus,sp7021-thermal.yaml
Please name the bindings "sunplus,sp7021-thermal.yaml", change the $id
and maintainers entry to new filename.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-07-13 7:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 7:30 [PATCH v10 0/2] Add thermal control driver for Sunplus SoC Li-hao Kuo
2022-07-12 7:30 ` [PATCH v10 1/2] thermal: Add thermal driver for Sunplus Li-hao Kuo
2022-07-13 7:52 ` Krzysztof Kozlowski
2022-07-14 5:32 ` Lh Kuo 郭力豪
2022-07-14 6:50 ` Krzysztof Kozlowski
2022-07-21 3:04 ` kernel test robot
2022-07-21 6:32 ` Krzysztof Kozlowski
2022-07-12 7:30 ` [PATCH v10 2/2] dt-bindings: thermal: Add Sunplus schema Li-hao Kuo
2022-07-13 7:50 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27cd6e98-50c6-14b2-aec0-b4bbd49a9da8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lh.kuo@sunplus.com \
--cc=lhjeff911@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).