From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258EBC4167B for ; Mon, 7 Dec 2020 13:33:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7F86233A0 for ; Mon, 7 Dec 2020 13:33:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726492AbgLGNdj (ORCPT ); Mon, 7 Dec 2020 08:33:39 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:33541 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbgLGNdi (ORCPT ); Mon, 7 Dec 2020 08:33:38 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20201207133243euoutp02a07eaff1232f3828b35d363c2d162b88~OcnTwTsL90185601856euoutp02d; Mon, 7 Dec 2020 13:32:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20201207133243euoutp02a07eaff1232f3828b35d363c2d162b88~OcnTwTsL90185601856euoutp02d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1607347963; bh=ljQ0v3Ar0KYP2q9/GRtPG9FJKYzmsBEMPJYT7bas0xM=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=YXnyfI3nXv1DhFtGBhw8rjlj6OWDgzzqG6ggdFQv6tUUzN+M3UpHev4Lt5w3dDEeq JsY5rsqNM4QlBu8xSwpaGb6jN+Unr+zoWvEul+H0F5kLgpcw0eew3NnzrXCdwSiqr5 8/gkKlmm/vhkZki1ZiEurX6kzTnv6KS7IUhhgWLQ= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20201207133237eucas1p19e9329c72365b51bdbaafba28239f22c~OcnOVcZch0957309573eucas1p1O; Mon, 7 Dec 2020 13:32:37 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id D4.52.44805.5FE2ECF5; Mon, 7 Dec 2020 13:32:37 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20201207133237eucas1p26f8484944760a14e51dc7353ed33cd28~OcnNreb_Q1175011750eucas1p2A; Mon, 7 Dec 2020 13:32:37 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201207133237eusmtrp22a886004009ed21a7d1310c91ddd5534~OcnNp8qpM0370603706eusmtrp2Q; Mon, 7 Dec 2020 13:32:37 +0000 (GMT) X-AuditID: cbfec7f4-b4fff7000000af05-d5-5fce2ef51212 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 2B.33.21957.4FE2ECF5; Mon, 7 Dec 2020 13:32:36 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20201207133234eusmtip21bd44750aa26b3a6918e1852376589e6~OcnLrilqA0874408744eusmtip2c; Mon, 7 Dec 2020 13:32:34 +0000 (GMT) Subject: Re: [PATCH v4 2/7] Input: use input_device_enabled() To: Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-input@vger.kernel.org, linux-tegra@vger.kernel.org, patches@opensource.cirrus.com, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Cc: "Rafael J . Wysocki" , Len Brown , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Kukjin Kim , Krzysztof Kozlowski , Dmitry Torokhov , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Sylvain Lemieux , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Barry Song , Michael Hennerich , Nick Dyer , Hans de Goede , Ferruh Yigit , Sangwon Jee , Peter Hutterer , Henrique de Moraes Holschuh , kernel@collabora.com, Bartlomiej Zolnierkiewicz From: Marek Szyprowski Message-ID: <27ce1176-6318-45aa-4e22-3dec9f3df15d@samsung.com> Date: Mon, 7 Dec 2020 14:32:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20200608112211.12125-3-andrzej.p@collabora.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA01Ta1BUZRj223PZA7VyuCTfYMQMGjOQsVKN81lmkFhnyJnITBumCdc4XAqQ diXDmZKLoWwwayiw7hIoLRcXBVmuu8htl2RkYQloI0UoAnFDwLjIXYjlYPHved/3ed7nfb6Z j8IcJkkXKiL6BCuOFkW6k7Z41a1508uPvU3BO5Myt6GCwX4clclLCTSkT8OQIc8CUPOEAUcD 5vfRaEsWDykNe1D28HWAzv6VQqA/E9U8dEaRh6NyUyqB1BlaHMkGH2JItzKKoY6OG3ykupBL oPz6YhxpB8ZIVFgvA0gz+BuBcprHcSRduIqhO5MzBOrWZZNoKq0ZIHlHPQ+lTCtIdN5Qzkdd l77H0NSjBgJV1zXwUPFNC4YWdbf4qM3YRaAn1RocWSqcUbpejOZ1OThaWUjCfD2ZEbMfU9On AkxyYgSjVfTxmX8mPmUWGwGjUaeQTLnqNFN7eYrHzMrbAKMa1RPM8pWLOJOWNE4yZeM1PCYr ewUwsic7A7cE2e4JYSMjvmLFwr1HbcMzagNjDAe+VpfQ8UDrLwUUBenXYFtriBTYUA50EYAp TQc5PA1gZg0tBbareArAny7c5VsHVn5VrZzkSIUAmnujONIEgLMjM4R1qSP9Jsy+uN/ad6KV GPw7vRJYC4yOt4GVvWdwq5qkfaB0TLq2SUDvhd26ojWM09uhqq6OsOLn6GOwVDq3zrGHty8N rWltVg0eylrWMEa7waRKJcZhZ3h3KJdnNYP0uWdg3lUDzp3tD8f7zYDDjnCkpWI9zvNwRftU kATggOk6nytSAexOlK8r3oD3TAukNRtGe8JSnZBr+8F7xRqCe8fN8Pcxe+6IzTC9Kgvj2gJ4 LtmBY3tARUvJf7ZNv3Rh54G7YkM0xYY4ig1xFP/7Xga4GjizsZKoMFbySjR70lsiipLERod5 f3Y8SgNWv4VxuWW6BhSOTHjrAY8CegApzN1J4OHSHuwgCBHFnWLFx4PFsZGsRA+2Uri7s+BY xbVgBzpMdIL9gmVjWPHTKY+ycYnnSXs+ESUY5FvNJQnONz/f5Cg28fdPxShDk384mnpox5cB 2S7z9uzIs66V41d63v75oDoqf16YMCAfatok69l9f1E2/O2D3W5dXsb35o1u4j8yam/Ej+o+ bF4S5IU9yNznOvajb31OropKEH5ATRYHbd8RUH07ThbS+86Bfvv05V2pRTXyMEvi6fylXX1+ 9ebidkuo8mSMk1eBbu5XxfSRPrXv2cPGvi0fVe5b+jhuOSu10S5I8yijMTC8IS4ix8X/pWVl byvZdFhotAgfFxwpi3E9JfhG275t9t1DMM/jrRc1ps7OUs+ezlcDJOZhqdDu2swLPqFdPq/P YRV37O5/19rpmL/ijkvCRT5emFgi+heBzm97hQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0xTdxTH/d1HHxrMpYDcNWNznTNxjtoCZYcFiC4+rmyJbslMHNOu4OWR QWtaMG7JHCsOpELwwcvCAFmZWqfDVh4FoVvLQALI0ECEQFfkMQYFZXQzKNDxWsJ/n5xzPt+T kxweLviOI+QlKlNYtVKRJOJsJNoXWx2BbvEDucSsDYUfhx0E3Cn6mYQRWw4O9opxBM0zdgKG eg6Bq7UQg2J7OJSM3UKQ+SSLBKfWiMFZfQUB5gfZJBjzLQTkDk/iUO9x4dDVVcUFw+UyEiqb bhJgGZriwLWmXASm4V4SSpunCdC9uIFD39//kvCovoQDsznNCIq6mjDIcus5cMFu5sLDK+dx mH1qJaG20YrBzXvjOLysb+FCR/tDEhZqTQSM3/WHSzY1zNWXEuB5kY7v3sFM9Oxh6gYNiMnQ JjIW/SCXeTZznHn5C2JMxiwOYzZ8wzSUz2LM86IOxBhcNpJZvJpHMDnp0xzmznQdxhSWeBCT uyA5vOVTcbhalZrCbk1QaVIiRNFSCBJLw0AcFBImlga/e+y9IJloV2T4CTYp8RSr3hX5uTgh v+HwSfuHp423qTRk2atDfB5NhdA1DUUcHdrIE1CViB6rshCrjVfptoI0cpV96Ple3drQU0Tn deQhHeLxfKgIuiRv33LdlyrGac+3v63IOJXBp6cmdi6zgPoB0f0N/GXmUFJaN7UcxOd5UZH0 o/rrK0xQ22hDYyO5nOlHxdCd7d6rI95025WRlUj+0qrJ3Na1+FC61DyEr/LrdHp18Rr70/0j ZdgFJNCv0/XrFP06Rb9OKUeEEfmyqZrk+GSNVKxRJGtSlfHiWFWyCS39Y03LnLkOlU7MiG0I 4yEbonm4yNdru7BTLvA6ofjyK1atkqtTk1iNDcmWzrmIC/1iVUsPrUyRS0MlMmlIaJhEFhYa LPL3qv7+J7mAileksF+w7ElW/b+H8fjCNMx0V0aMxZt+v6HPDkRx9/dap0yjaTPJ/KSMY85N m6OqWiqm/xyQQIzH50jE/lq3t49vd6GjN/CU6o1L7bfbRI/fmXRynmRqPpg6vnP7wOZKKH1W 95oyaceZRP1gX/nWoz1+vSNVRr5PPnf/XxvaDgjOmx5HBVHuAKf3uc732fzoy7eQ5OvRoIt5 Z8cPOhuiDwqvtwlFwbHaAPqMy2nNcec2/mogs1u9A6LIyCOT1oCY4eru4U8KZOe0b5bNj8qf 438ciBO+dW+3clOUdHbuH7PScX/wWt+A47RpA0S3H21+pebjQy6PJM6duUVv3TP/Uc9iYUVn Wkd/WIHR0P3ZvgVMRGgSFNK3cbVG8R+NMNSPGAQAAA== X-CMS-MailID: 20201207133237eucas1p26f8484944760a14e51dc7353ed33cd28 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20201207133237eucas1p26f8484944760a14e51dc7353ed33cd28 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201207133237eucas1p26f8484944760a14e51dc7353ed33cd28 References: <2336e15d-ff4b-bbb6-c701-dbf3aa110fcd@redhat.com> <20200608112211.12125-1-andrzej.p@collabora.com> <20200608112211.12125-3-andrzej.p@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrzej, On 08.06.2020 13:22, Andrzej Pietrasiewicz wrote: > Use the newly added helper in relevant input drivers. > > Signed-off-by: Andrzej Pietrasiewicz This patch landed recently in linux-next as commit d69f0a43c677 ("Input: use input_device_enabled()"). Sadly it causes following warning during system suspend/resume cycle on ARM 32bit Samsung Exynos5250-based Snow Chromebook with kernel compiled from exynos_defconfig: ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1777 at drivers/input/input.c:2230 input_device_enabled+0x68/0x6c Modules linked in: cmac bnep mwifiex_sdio mwifiex sha256_generic libsha256 sha256_arm cfg80211 btmrvl_sdio btmrvl bluetooth s5p_mfc exynos_gsc v4l2_mem2mem videob CPU: 0 PID: 1777 Comm: rtcwake Not tainted 5.10.0-rc6-next-20201207-00001-g49a0dc04c46d-dirty #9902 Hardware name: Samsung Exynos (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0xb4/0xd4) [] (dump_stack) from [] (__warn+0xd8/0x11c) [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8) [] (warn_slowpath_fmt) from [] (input_device_enabled+0x68/0x6c) [] (input_device_enabled) from [] (cyapa_gen3_set_power_mode+0x128/0x1cc) [] (cyapa_gen3_set_power_mode) from [] (cyapa_suspend+0x74/0x114) [] (cyapa_suspend) from [] (dpm_run_callback+0xb0/0x3c8) [] (dpm_run_callback) from [] (__device_suspend+0x104/0x784) [] (__device_suspend) from [] (dpm_suspend+0x184/0x540) [] (dpm_suspend) from [] (dpm_suspend_start+0x98/0xa0) [] (dpm_suspend_start) from [] (suspend_devices_and_enter+0xec/0xbd4) [] (suspend_devices_and_enter) from [] (pm_suspend+0x314/0x42c) [] (pm_suspend) from [] (state_store+0x6c/0xc8) [] (state_store) from [] (kernfs_fop_write+0x10c/0x228) [] (kernfs_fop_write) from [] (vfs_write+0xc8/0x530) [] (vfs_write) from [] (ksys_write+0x60/0xd8) [] (ksys_write) from [] (ret_fast_syscall+0x0/0x2c) Exception stack(0xc45bffa8 to 0xc45bfff0) ... irq event stamp: 14101 hardirqs last  enabled at (14109): [] vprintk_emit+0x2d8/0x32c hardirqs last disabled at (14116): [] vprintk_emit+0x29c/0x32c softirqs last  enabled at (13264): [] __do_softirq+0x528/0x684 softirqs last disabled at (13253): [] irq_exit+0x1ec/0x1f8 ---[ end trace 6687a21e6b7e94a9 ]--- ------------[ cut here ]------------ WARNING: CPU: 1 PID: 1777 at drivers/input/input.c:2230 input_device_enabled+0x68/0x6c Modules linked in: cmac bnep mwifiex_sdio mwifiex sha256_generic libsha256 sha256_arm cfg80211 btmrvl_sdio btmrvl bluetooth s5p_mfc exynos_gsc v4l2_mem2mem videob CPU: 1 PID: 1777 Comm: rtcwake Tainted: G        W 5.10.0-rc6-next-20201207-00001-g49a0dc04c46d-dirty #9902 Hardware name: Samsung Exynos (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0xb4/0xd4) [] (dump_stack) from [] (__warn+0xd8/0x11c) [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8) [] (warn_slowpath_fmt) from [] (input_device_enabled+0x68/0x6c) [] (input_device_enabled) from [] (cyapa_gen3_set_power_mode+0x128/0x1cc) [] (cyapa_gen3_set_power_mode) from [] (cyapa_reinitialize+0xcc/0x154) [] (cyapa_reinitialize) from [] (cyapa_resume+0x48/0x98) [] (cyapa_resume) from [] (dpm_run_callback+0xb0/0x3c8) [] (dpm_run_callback) from [] (device_resume+0xbc/0x260) [] (device_resume) from [] (dpm_resume+0x14c/0x51c) [] (dpm_resume) from [] (dpm_resume_end+0xc/0x18) [] (dpm_resume_end) from [] (suspend_devices_and_enter+0x1b4/0xbd4) [] (suspend_devices_and_enter) from [] (pm_suspend+0x314/0x42c) [] (pm_suspend) from [] (state_store+0x6c/0xc8) [] (state_store) from [] (kernfs_fop_write+0x10c/0x228) [] (kernfs_fop_write) from [] (vfs_write+0xc8/0x530) [] (vfs_write) from [] (ksys_write+0x60/0xd8) [] (ksys_write) from [] (ret_fast_syscall+0x0/0x2c) Exception stack(0xc45bffa8 to 0xc45bfff0) ... irq event stamp: 55479 hardirqs last  enabled at (55487): [] vprintk_emit+0x2d8/0x32c hardirqs last disabled at (55494): [] vprintk_emit+0x29c/0x32c softirqs last  enabled at (53552): [] __do_softirq+0x528/0x684 softirqs last disabled at (53541): [] irq_exit+0x1ec/0x1f8 ---[ end trace 6687a21e6b7e94aa ]--- ------------[ cut here ]------------ WARNING: CPU: 1 PID: 1777 at drivers/input/input.c:2230 input_device_enabled+0x68/0x6c Modules linked in: cmac bnep mwifiex_sdio mwifiex sha256_generic libsha256 sha256_arm cfg80211 btmrvl_sdio btmrvl bluetooth s5p_mfc exynos_gsc v4l2_mem2mem videob CPU: 1 PID: 1777 Comm: rtcwake Tainted: G        W 5.10.0-rc6-next-20201207-00001-g49a0dc04c46d-dirty #9902 Hardware name: Samsung Exynos (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0xb4/0xd4) [] (dump_stack) from [] (__warn+0xd8/0x11c) [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8) [] (warn_slowpath_fmt) from [] (input_device_enabled+0x68/0x6c) [] (input_device_enabled) from [] (cyapa_reinitialize+0x4c/0x154) [] (cyapa_reinitialize) from [] (cyapa_resume+0x48/0x98) [] (cyapa_resume) from [] (dpm_run_callback+0xb0/0x3c8) [] (dpm_run_callback) from [] (device_resume+0xbc/0x260) [] (device_resume) from [] (dpm_resume+0x14c/0x51c) [] (dpm_resume) from [] (dpm_resume_end+0xc/0x18) [] (dpm_resume_end) from [] (suspend_devices_and_enter+0x1b4/0xbd4) [] (suspend_devices_and_enter) from [] (pm_suspend+0x314/0x42c) [] (pm_suspend) from [] (state_store+0x6c/0xc8) [] (state_store) from [] (kernfs_fop_write+0x10c/0x228) [] (kernfs_fop_write) from [] (vfs_write+0xc8/0x530) [] (vfs_write) from [] (ksys_write+0x60/0xd8) [] (ksys_write) from [] (ret_fast_syscall+0x0/0x2c) Exception stack(0xc45bffa8 to 0xc45bfff0) ... irq event stamp: 55829 hardirqs last  enabled at (55837): [] vprintk_emit+0x2d8/0x32c hardirqs last disabled at (55844): [] vprintk_emit+0x29c/0x32c softirqs last  enabled at (53552): [] __do_softirq+0x528/0x684 softirqs last disabled at (53541): [] irq_exit+0x1ec/0x1f8 ---[ end trace 6687a21e6b7e94ab ]--- ------------[ cut here ]------------ WARNING: CPU: 1 PID: 1777 at drivers/input/input.c:2230 input_device_enabled+0x68/0x6c Modules linked in: cmac bnep mwifiex_sdio mwifiex sha256_generic libsha256 sha256_arm cfg80211 btmrvl_sdio btmrvl bluetooth s5p_mfc exynos_gsc v4l2_mem2mem videob CPU: 1 PID: 1777 Comm: rtcwake Tainted: G        W 5.10.0-rc6-next-20201207-00001-g49a0dc04c46d-dirty #9902 Hardware name: Samsung Exynos (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0xb4/0xd4) [] (dump_stack) from [] (__warn+0xd8/0x11c) [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8) [] (warn_slowpath_fmt) from [] (input_device_enabled+0x68/0x6c) [] (input_device_enabled) from [] (cyapa_gen3_set_power_mode+0x128/0x1cc) [] (cyapa_gen3_set_power_mode) from [] (cyapa_reinitialize+0xa8/0x154) [] (cyapa_reinitialize) from [] (cyapa_resume+0x48/0x98) [] (cyapa_resume) from [] (dpm_run_callback+0xb0/0x3c8) [] (dpm_run_callback) from [] (device_resume+0xbc/0x260) [] (device_resume) from [] (dpm_resume+0x14c/0x51c) [] (dpm_resume) from [] (dpm_resume_end+0xc/0x18) [] (dpm_resume_end) from [] (suspend_devices_and_enter+0x1b4/0xbd4) [] (suspend_devices_and_enter) from [] (pm_suspend+0x314/0x42c) [] (pm_suspend) from [] (state_store+0x6c/0xc8) [] (state_store) from [] (kernfs_fop_write+0x10c/0x228) [] (kernfs_fop_write) from [] (vfs_write+0xc8/0x530) [] (vfs_write) from [] (ksys_write+0x60/0xd8) [] (ksys_write) from [] (ret_fast_syscall+0x0/0x2c) Exception stack(0xc45bffa8 to 0xc45bfff0) ... irq event stamp: 56143 hardirqs last  enabled at (56151): [] vprintk_emit+0x2d8/0x32c hardirqs last disabled at (56158): [] vprintk_emit+0x29c/0x32c softirqs last  enabled at (53552): [] __do_softirq+0x528/0x684 softirqs last disabled at (53541): [] irq_exit+0x1ec/0x1f8 ---[ end trace 6687a21e6b7e94ac ]--- Let me know how I can help debugging this issue. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland