From: Phil Elwell <phil@raspberrypi.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/4] lan78xx: Read initial EEE setting from Device Tree
Date: Thu, 12 Apr 2018 16:17:04 +0100 [thread overview]
Message-ID: <27e04eb4-bf75-d5ad-c0dc-bc0153fd8769@raspberrypi.org> (raw)
In-Reply-To: <20180412141630.GM28963@lunn.ch>
Andrew,
On 12/04/2018 15:16, Andrew Lunn wrote:
> On Thu, Apr 12, 2018 at 02:55:34PM +0100, Phil Elwell wrote:
>> Add two new Device Tree properties:
>> * microchip,eee-enabled - a boolean to enable EEE
>> * microchip,tx-lpi-timer - time in microseconds to wait after TX goes
>> idle before entering the low power state
>> (default 600)
>
> Hi Phil
>
> This looks wrong.
>
> What should happen is that the MAC driver calls phy_init_eee() to find
> out if the PHY supports EEE. There should be no need to look in device
> tree.
If the driver should be calling phy_init_eee to initialise EEE operation then I'm fine
with that (although I notice that the TI cpsw calls phy_ethtool_set_eee but I don't see
it calling phy_init_eee). However, it sounds like I need to keep my DT toggle of the
EEE enablement and parameters downstream.
Phil
next prev parent reply other threads:[~2018-04-12 15:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 13:55 [PATCH 0/4] lan78xx: Read configuration from Device Tree Phil Elwell
2018-04-12 13:55 ` [PATCH 1/4] lan78xx: Read MAC address from DT if present Phil Elwell
2018-04-12 14:06 ` Andrew Lunn
2018-04-12 14:18 ` Phil Elwell
2018-04-12 13:55 ` [PATCH 2/4] lan78xx: Read initial EEE setting from Device Tree Phil Elwell
2018-04-12 14:16 ` Andrew Lunn
2018-04-12 15:17 ` Phil Elwell [this message]
2018-04-12 13:55 ` [PATCH 3/4] lan78xx: Read LED modes " Phil Elwell
2018-04-12 14:26 ` Andrew Lunn
2018-04-12 14:30 ` Phil Elwell
2018-04-12 14:36 ` Andrew Lunn
2018-04-12 15:21 ` Woojung.Huh
2018-04-12 13:55 ` [PATCH 4/4] dt-bindings: Document the DT bindings for lan78xx Phil Elwell
2018-04-12 14:04 ` Andrew Lunn
2018-04-12 14:10 ` Phil Elwell
2018-04-12 14:17 ` Andrew Lunn
2018-04-12 14:30 ` Andrew Lunn
2018-04-12 14:33 ` Phil Elwell
2018-04-16 19:22 ` Rob Herring
2018-04-17 11:35 ` Phil Elwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27e04eb4-bf75-d5ad-c0dc-bc0153fd8769@raspberrypi.org \
--to=phil@raspberrypi.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).