linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ferry Toth <fntoth@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Eric Biggers <ebiggers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Raul E Rangel <rrangel@chromium.org>,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v3 0/5] mmc: sdhci-pci: Remove dead code and deduplicate
Date: Wed, 20 Oct 2021 22:58:21 +0200	[thread overview]
Message-ID: <27fbd7d6-3d44-39f4-9589-06dc6deed572@gmail.com> (raw)
In-Reply-To: <20211014132613.27861-1-andriy.shevchenko@linux.intel.com>

Hi,
Op 14-10-2021 om 15:26 schreef Andy Shevchenko:
> It appears that one of the supported platform magically worked with
> the custom IRQ handler (any hints how?) while having two PCB designs
> with an opposite CD sense level. Quirking it out reveals the code
> duplication and dead code.
> 
> Patch 1 is code deduplication to save few LOCs.
> Patch 2-5 are dead code removals.

Tested-by: Ferry Toth <ftoth@exalondelft.nl> @ Intel Edison-Arduino board

> In v3:
> - dropped the fix as it has been applied (Ulf)
> - added tag (Adrian)
> - elaborated commit IDs with their short descriptions in patch 3 (Adrian)
> - corrected dependency in patch 5 (Adrian)
> 
> In v2:
> - redone fix to use ->get_cd() instead of quirks (Adrian)
> - due to above transformed previous clean up to the current patch 2
> - added a new patch, i.e. patch 3
> - added commit IDs to patch 4 (Adrian)
> - mentioned dependencies on previous patches in patch 5 and 6 (Adrian)
> 
> Andy Shevchenko (5):
>    mmc: sdhci: Deduplicate sdhci_get_cd_nogpio()
>    mmc: sdhci: Remove unused prototype declaration in the header
>    mmc: sdhci-pci: Remove dead code (struct sdhci_pci_data et al)
>    mmc: sdhci-pci: Remove dead code (cd_gpio, cd_irq et al)
>    mmc: sdhci-pci: Remove dead code (rst_n_gpio et al)
> 
>   drivers/mmc/host/Makefile          |   1 -
>   drivers/mmc/host/sdhci-acpi.c      |  14 +--
>   drivers/mmc/host/sdhci-pci-core.c  | 152 +----------------------------
>   drivers/mmc/host/sdhci-pci-data.c  |   6 --
>   drivers/mmc/host/sdhci-pci.h       |   5 -
>   drivers/mmc/host/sdhci.c           |  19 ++++
>   drivers/mmc/host/sdhci.h           |   2 +-
>   include/linux/mmc/sdhci-pci-data.h |  18 ----
>   8 files changed, 26 insertions(+), 191 deletions(-)
>   delete mode 100644 drivers/mmc/host/sdhci-pci-data.c
>   delete mode 100644 include/linux/mmc/sdhci-pci-data.h
> 


      parent reply	other threads:[~2021-10-20 20:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 13:26 [PATCH v3 0/5] mmc: sdhci-pci: Remove dead code and deduplicate Andy Shevchenko
2021-10-14 13:26 ` [PATCH v3 1/5] mmc: sdhci: Deduplicate sdhci_get_cd_nogpio() Andy Shevchenko
2021-10-14 13:26 ` [PATCH v3 2/5] mmc: sdhci: Remove unused prototype declaration in the header Andy Shevchenko
2021-10-14 13:26 ` [PATCH v3 3/5] mmc: sdhci-pci: Remove dead code (struct sdhci_pci_data et al) Andy Shevchenko
2021-10-14 13:26 ` [PATCH v3 4/5] mmc: sdhci-pci: Remove dead code (cd_gpio, cd_irq " Andy Shevchenko
2021-10-14 13:26 ` [PATCH v3 5/5] mmc: sdhci-pci: Remove dead code (rst_n_gpio " Andy Shevchenko
2021-10-19 11:36 ` [PATCH v3 0/5] mmc: sdhci-pci: Remove dead code and deduplicate Ulf Hansson
2021-10-20 20:58 ` Ferry Toth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27fbd7d6-3d44-39f4-9589-06dc6deed572@gmail.com \
    --to=fntoth@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ebiggers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=rrangel@chromium.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).