From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9326C43467 for ; Thu, 8 Oct 2020 10:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 501FB21734 for ; Thu, 8 Oct 2020 10:46:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=connolly.tech header.i=@connolly.tech header.b="M/b+CvGi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729568AbgJHKqO (ORCPT ); Thu, 8 Oct 2020 06:46:14 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:61503 "EHLO mail-40134.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726760AbgJHKqL (ORCPT ); Thu, 8 Oct 2020 06:46:11 -0400 X-Greylist: delayed 5141 seconds by postgrey-1.27 at vger.kernel.org; Thu, 08 Oct 2020 06:46:10 EDT Date: Thu, 08 Oct 2020 10:46:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech; s=protonmail; t=1602153968; bh=4NpRlPMJu+nTJ3BKK9VVYitJouPdmM13RaANueWkDgQ=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=M/b+CvGihVDhlxXveZ6bFw8LtfVyCrMfp5EQWimoFjBHy9QeS0/AVh9n4yQYnqkQr kWaMjO9Xjlg3TnUtt+onWkCCp/wbn1PzQnRqMGSR+CZg0+8sezo6Z5tdRifOilEg4m KAPVi5jBX6OFFiQg4M7GHSLU51+Nmk5/L7UJiQeQ= To: Wolfram Sang From: Caleb Connolly Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Akash Asthana , Mukesh Savaliya , ~postmarketos/upstreaming@lists.sr.ht, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Caleb Connolly Subject: Re: Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6 Message-ID: <27ffa058-c800-4ce7-4db5-8896ad136abf@connolly.tech> In-Reply-To: <20201008100352.GF76290@ninjato> References: <20201007174736.292968-1-caleb@connolly.tech> <20201007174736.292968-6-caleb@connolly.tech> <20201008100352.GF76290@ninjato> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-10-08 11:03, Wolfram Sang wrote: > On Wed, Oct 07, 2020 at 05:49:35PM +0000, Caleb Connolly wrote: >> The OnePlus 6/T has the same issues as the c630 causing a crash when DMA >> is used for i2c, so disable it. >> >> https://patchwork.kernel.org/patch/11133827/ >> Signed-off-by: Caleb Connolly > May I ask for a quick review here, so we can get this into 5.9 if > qcom-geni maintainers agree this is good to go? Sorry it wasn't mentioned in my first message, this patch depends on the=20 rest in the series found here:=20 https://lore.kernel.org/linux-arm-msm/20201007174736.292968-1-caleb@connoll= y.tech/#r >> --- >> drivers/i2c/busses/i2c-qcom-geni.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c= -qcom-geni.c >> index dead5db3315a..50a0674a6553 100644 >> --- a/drivers/i2c/busses/i2c-qcom-geni.c >> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >> @@ -358,7 +358,8 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *= gi2c, struct i2c_msg *msg, >> =09struct geni_se *se =3D &gi2c->se; >> =09size_t len =3D msg->len; >> =20 >> -=09if (!of_machine_is_compatible("lenovo,yoga-c630")) >> +=09if (!of_machine_is_compatible("lenovo,yoga-c630") && >> +=09 !of_machine_is_compatible("oneplus,oneplus6")) >> =09=09dma_buf =3D i2c_get_dma_safe_msg_buf(msg, 32); >> =20 >> =09if (dma_buf) >> @@ -400,7 +401,8 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *= gi2c, struct i2c_msg *msg, >> =09struct geni_se *se =3D &gi2c->se; >> =09size_t len =3D msg->len; >> =20 >> -=09if (!of_machine_is_compatible("lenovo,yoga-c630")) >> +=09if (!of_machine_is_compatible("lenovo,yoga-c630") && >> +=09 !of_machine_is_compatible("oneplus,oneplus6")) >> =09=09dma_buf =3D i2c_get_dma_safe_msg_buf(msg, 32); >> =20 >> =09if (dma_buf) >> --=20 >> 2.28.0 >> >>