From: "Weiny, Ira" <ira.weiny@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: "Björn Töpel" <bjorn.topel@gmail.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Linux MM" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Topel, Bjorn" <bjorn.topel@intel.com>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>,
Netdev <netdev@vger.kernel.org>,
"Davidlohr Bueso" <dbueso@suse.de>
Subject: RE: [PATCH 1/2] xsk: do not use mmap_sem
Date: Mon, 11 Feb 2019 17:16:06 +0000 [thread overview]
Message-ID: <2807E5FD2F6FDA4886F6618EAC48510E79BCB3B9@CRSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <CAPcyv4gjUmRdV1jZegLecocj155m7dpQLxQSnF_HQQErD8Gtag@mail.gmail.com>
> > >> ---
> > >> net/xdp/xdp_umem.c | 6 ++----
> > >> 1 file changed, 2 insertions(+), 4 deletions(-)
> > >>
> > >> diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c index
> > >> 5ab236c5c9a5..25e1e76654a8 100644
> > >> --- a/net/xdp/xdp_umem.c
> > >> +++ b/net/xdp/xdp_umem.c
> > >> @@ -265,10 +265,8 @@ static int xdp_umem_pin_pages(struct
> xdp_umem *umem)
> > >> if (!umem->pgs)
> > >> return -ENOMEM;
> > >>
> > >> - down_write(¤t->mm->mmap_sem);
> > >> - npgs = get_user_pages(umem->address, umem->npgs,
> > >> - gup_flags, &umem->pgs[0], NULL);
> > >> - up_write(¤t->mm->mmap_sem);
> > >> + npgs = get_user_pages_fast(umem->address, umem->npgs,
> > >> + gup_flags, &umem->pgs[0]);
> > >>
> > >
> > > Thanks for the patch!
> > >
> > > The lifetime of the pinning is similar to RDMA umem mapping, so
> > > isn't gup_longterm preferred?
> >
> > Seems reasonable from reading what gup_longterm seems to do. Davidlohr
> > or Dan, any thoughts on the above?
>
> Yes, any gup where the lifetime of the corresponding put_page() is under
> direct control of userspace should be using the _longterm flavor to
> coordinate be careful in the presence of dax. In the dax case there is no page
> cache indirection to coordinate truncate vs page pins. Ira is looking to add a
> "fast + longterm" flavor for cases like this.
Yes I'm just about ready with a small patch set to add a GUP fast longterm.
I think this should wait for that series.
Ira
next prev parent reply other threads:[~2019-02-11 17:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 5:37 [PATCH -tip 0/2] more get_user_pages mmap_sem cleanups Davidlohr Bueso
2019-02-07 5:37 ` [PATCH 1/2] xsk: do not use mmap_sem Davidlohr Bueso
2019-02-07 7:43 ` Björn Töpel
2019-02-11 15:33 ` Daniel Borkmann
2019-02-11 16:37 ` Dan Williams
2019-02-11 17:16 ` Weiny, Ira [this message]
2019-02-11 16:15 ` [PATCH v2] xsk: share the mmap_sem for page pinning Davidlohr Bueso
2019-02-11 16:21 ` Björn Töpel
2019-02-11 19:53 ` Daniel Borkmann
2019-02-07 5:37 ` [PATCH 2/2] MIPS/c-r4k: do no use mmap_sem for gup_fast() Davidlohr Bueso
2019-02-07 19:00 ` Paul Burton
2019-02-07 19:25 ` Davidlohr Bueso
2019-02-07 5:50 ` [PATCH -tip 0/2] more get_user_pages mmap_sem cleanups Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2807E5FD2F6FDA4886F6618EAC48510E79BCB3B9@CRSMSX101.amr.corp.intel.com \
--to=ira.weiny@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@iogearbox.net \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).