From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754168AbdKFQRX (ORCPT ); Mon, 6 Nov 2017 11:17:23 -0500 Received: from mail-co1nam03on0065.outbound.protection.outlook.com ([104.47.40.65]:60034 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753043AbdKFQRB (ORCPT ); Mon, 6 Nov 2017 11:17:01 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v7 20/38] crypto: ccp: Implement SEV_PDH_CERT_EXPORT ioctl command To: Borislav Petkov References: <20171101211623.71496-1-brijesh.singh@amd.com> <20171101211623.71496-21-brijesh.singh@amd.com> <20171105113412.2xtuifkbmxwrf3ji@pd.tnic> From: Brijesh Singh Message-ID: <280a3443-3268-5c11-4e7d-0d7874060730@amd.com> Date: Mon, 6 Nov 2017 10:16:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171105113412.2xtuifkbmxwrf3ji@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR03CA0058.namprd03.prod.outlook.com (10.173.137.20) To CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6eedbf87-0382-47ad-aaf5-08d52531cea5 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603249);SRVR:CY1PR12MB0151; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;3:yKv68KJSuropRvIGF8M091ENv7Le04Pyh+reqoR8CK1v2VydHY+9BMXRklEsYd9Pvm9qsGAAhElRwESYywRbjh+zTc613S2zOIaSaePyNLh8/a/qoq8lzQf0NCrlHIcZwWlyl/MMH/sZPuohXALlwdnj6jhoMKo+rUyLh+sXn4YDyspja/kFV8opTivNRgMHcq3LE+dtvAq3rtDsHCtPakgsv0GFprBFfDilrRauMSKC45VVtPgYNCvHwtJF4in6;25:s3Fu/2DQxc9esmKmOLb3TMbKZ6s91OIL56zZCocAzDkYTCH6K8c4/pTBeO2Rmj67DTfC1XBeO8GiqKCWFa+rPSIQu4v1HpKP/YwkI8li6E7XZQT8DVi05RpU/2S2g1j3tLrZc555f1Q+3ilK29cKSjxhG6p/4sDfQxc+LzsPtFYGPR7II25WEeUV2edCHAWvIjAwy+9YtP58nGshxAvq7rA+4qF7tTghqoy1U2BEyRuWuj9jCGboo3Kgn17ufGv2Lf9v8kFYW6cZpvgVFp6JWutMx/YFCdeDhPCPGkUC972EQrRYZFMIJR1MKmWhbrpsvGavPSn2v4+zNTBTqtSgZA==;31:JvuQEEA+JhMet403P8YGDtqDyQfRIHbW9x4SAX4LKVhiYYlKX2s82AY1R8crWUlq3p6AurhJ37ERB2LyMOkuOrBFq9Ytr4+FjEojiUU3wYdklDTGFocuZWjUZ5VxnctuUqHOrYGDxtHWt/tg5pILDh3L9W9Th12jR9XLj2KWvyiCvbRqIJBk+HuQGEWaDfjJ4ZmL3hf9UuNQ7rl3E9CS3cO5S7SwqVjnaSLv+RSZGfg= X-MS-TrafficTypeDiagnostic: CY1PR12MB0151: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;20:h+VeJcs1TNkTnKZ5K9JWgwg08VHzkpOJTWrHXVicq0qZ6QQsbI5nBIe4GTJ+3y2T86gv6tygjlWCBtR1MT5mWx5XitigkZIMpPmISfdV+sZ4apTjVHdEn1vq3S//zYHS0/jludJxPAtO+/oKXRfP3YAN5lr5Erwm6ojBvnN8ckyR9BdDPu+Cooc8z0uxWGRmSK01GrNsSYMP/az+NY8cd1oUPjZBUS9ns9t6cRe4lC13GmCtJbqgo10nxL9e/Cl2cH8tSnPrbp3ijtSlvsb1ztP5Ikyl/2eA+7cf/QGAlWKWsdit73/6hlsg+TIJGP3P0DF5lPU2x9s833hBdvEfW1eIpk9hS42k4ro+3EL/RhS04vimSxd41BGPWBkSqcxuq7A4l+FMIGcoRO2iOUommrNIQPkKFwSVOJIKUmJWIYY1BkRtq429vsx42H0Smq0/bi/t56c+cV3DzH2a8+dC/wHyAsB77SgLCpfKWJKQnAeX7Fd20l2fmB56H6oN/m4h;4:Pg9wBFnC0rerX60Zw2OkjKlRLwOoikmayvRLxvGYOpmg1nlu5vvWxHQaw44QKXAbLpoPQOp4+oS9mgE6o0VgYifSbNxkfWa/AbDDbNsCNmxMFIZdYQMLggx8x5/I8Jmbsc+UzWjkXmBeerk/HgnRPkCrUyXPVbZzuTRKm5kQ/JcsP97Env48Z3y5FJ2RXSn8eTFCVql4xpR5QtAg+rne0/Xw1RlakGaoPt7PR8fZ9uWXh7DwzQ6FVpoWZ+lbtEy+VsIuEfzYm+8gwFb91iXzYg== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231021)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0151;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0151; X-Forefront-PRVS: 048396AFA0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(376002)(39860400002)(199003)(24454002)(189002)(6666003)(189998001)(65826007)(6916009)(65956001)(65806001)(31696002)(53936002)(2950100002)(5660300001)(33646002)(4326008)(2906002)(86362001)(66066001)(16526018)(97736004)(6246003)(53546010)(316002)(47776003)(25786009)(16576012)(58126008)(478600001)(23676003)(67846002)(36756003)(54906003)(83506002)(81156014)(230700001)(76176999)(101416001)(54356999)(50986999)(8936002)(90366009)(8676002)(7736002)(81166006)(229853002)(77096006)(6486002)(105586002)(68736007)(31686004)(305945005)(106356001)(64126003)(3846002)(6116002)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0151;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUxOzIzOmV5UHJ5Rnd1SkdocEczRkZBS0pUTVdTc2Qr?= =?utf-8?B?aHBQYkt3TVJWYmIyYW5oQWVaWUdnNFpUUldINmFvRlhkMmxJalpNT1g2cDdM?= =?utf-8?B?Rk96STd2bk9Cd2d1RW8yc3E0SlVJSk9kTThBUkxYVmtkSDBaemFqTkp3UGM2?= =?utf-8?B?QzY0UFM2RXFSdDkyLzVuSTRLZXNHL3FGbFo0V3J3U0pYemtCdGo2ajVvYlND?= =?utf-8?B?UVlaZFpjNFdEMDh5NlZKQTNudmQvbEk5YStBaXowZnMzbWZqc3B2WjV1enhD?= =?utf-8?B?MkxGdE1sTkFLckxSV0l4NVA4TllhV0IwcTcxYjJmQ0FUeStpMUgyTG1mcURS?= =?utf-8?B?R0N4TmF6K3kyMXVLWlptMEt3TVA3b0FTWmRxSlVTZ1ZNYnVPYk9YUTNUYjRi?= =?utf-8?B?VHcxNTNoNE05cURkZXNuRUM3SURhdnRjTUFBbXc3cjdOUnh1dEhmeHJUb3Ar?= =?utf-8?B?NnNFRmN1N0pOcGdld21WK2pZdE5uR2NRWEdWSEV5WWkyWWErM2x4ckkvbWxP?= =?utf-8?B?UTNZbDg3YmcySFF4a3VnSk96bytGZ214ZHY4VVFnaSt0R2hSL2lBNDI1WFBZ?= =?utf-8?B?anIxTkhnTWJwTGtNQ2E5SVEyaVZRRkJrK2kyUmVQbmdPeDNoVjA4N0xBaG4z?= =?utf-8?B?b1dOSnlPaGlqcEpNNTM5UndnMDBpMllrT3IvNzQ3L1l6dTNLRUpKQXlPcEw2?= =?utf-8?B?cDZWZ3R0SmMwSkYrR3ZUdE1WZDZwWXp6Y3lITFA3YnBCZzdEOTVreFdScnVL?= =?utf-8?B?Rnkyb1RrOHZYeXFST3FIQXQ3ZnhPcFRsajJPNkRXcEhpdXV5QVNuNkt5UGVa?= =?utf-8?B?bVlpYllPMzFLMEpkQ09JeDlaTnYrVkI1YkJza0U0Yk5RZWh2MzRiM1Rkd1lJ?= =?utf-8?B?YmdyNU1YeStPOWlQRlJYakdFMHVXR3hpSkhFZTcvaUI2NE9TQzlvMXFXbzRs?= =?utf-8?B?MW1rN2M4dzRXOGR2bTNPRVBIYTJONFV5NWVtMDZiQnFNZDFSVGpYZ0ZPZWtr?= =?utf-8?B?dG1zQUNqSzNvWmpIU3h0VzAzTXQ3MHpXM2tHSjF0eWliaHZTVlBIMC8vSmhm?= =?utf-8?B?QWVxTWlWdFFmZGM4TC9DRXd3Zks0eE5nVW5PZ0hFVVFVczBLc0ZoZ0I0MXBC?= =?utf-8?B?eFFLRkRGaHhjeGRwNmEzWnB5RkszcVkwWEo4RlhRMkZYU3o0N2t5VjYweWJO?= =?utf-8?B?Nk45eUwwZTdKMHpsKytFVFR0bWk3RFR3aFcvM0hpaEJXb0ZCdnpSVnRWM0Rn?= =?utf-8?B?K09nWldvKzBwdkNRajF4ZXZ1TVJqOUkyaXFUV3FGN29INktXUWJDbnZLaGox?= =?utf-8?B?SE41ZHVORnZFOUtxYjRueU9zSGtxTExSQk4yV3NXSG9OQnBKZGxpZURnNlpl?= =?utf-8?B?OS8rc0ZWN24reTNybEpmYzh0dkxwOFlEcEdKTTZRcDk3QitFNEdGazl5WThP?= =?utf-8?B?dE16YjczdEhsMXlUWnVVTW9JVGkxblpZRTZKSzhiSGl2S2VOQTI2czBRVklr?= =?utf-8?B?cFpxNmZ0TDI0RTZWYjFJaitlUTRMREk3dGlZODBkZmxUaHVTK1N5TEFobElo?= =?utf-8?B?NlAyanBSVEtvei9FRTZRbzJPSVFZQUtIMHk4ZU1jS3VSdVhRZEs1STc4WUl5?= =?utf-8?B?WEVQc2VGWFdWMC9WNVBpTG5hWXhGMjI5aTlMVWZ2amdwYnc1OEttclM3SDFy?= =?utf-8?B?RGIyenJzN2MvcXlQM21WT1B3dVNTWWVEdTJpUkRqM04zK3BydDVRQUR2WldM?= =?utf-8?B?czNSMFRXNHBrWHplMGEzZWhYeXpsQzllYUFxcjVYYnhnSzRLbmhQeC9FMnpr?= =?utf-8?B?Yk5xV3orNGZsWk9GbU52ZEpHVzYzMlBldnVPdGFaTDNXdXh5M2hyOHpvU1JR?= =?utf-8?Q?AMeime5WZZgolxqo6M3vcNfF1aHacaBE?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;6:187T2Mpvb8mkIOS7FMC2R0RMITOiSP9BJv4bLt/RHXmj4uA+Xb+5r2hCVdNFhofAtjrDrHnYCNZRZLqE/+BtLlzOhnQhSWz/dC3vlEmvvqNWkHhotlDaTRgUm5BM20lMEFhgum/2DMFueOpshY7xrjwX3D+lPGHo4FC5i7KrlaxvPvKyKWXKggTZ0/0YG0mZ5rrEZoSb8N/bfVBDV8umPzN+eNMC94mniDkx8jA9uaBWCcxJ6VtIbvbNLsJ9TuK2n7RCoI5zvrps+U9ZGKvghBNug+SWybKdTr16h8cEPwxMMJlXsSuFmW5quPCRiLv56CXFJva+4+cowSQ+3YeaeKXnaU/CEl/tBrx9Puf0JAk=;5:q/Wo80aCHJwb1sa46mZB20zRaRpydSc9oPMi2ARv/AvdOM6oC3fLRgPCI53KAqt8Cp19fDafjGHFfJBbJBSlF7ndBl7hqA9XVKtAk7iImkroD1ex7RBGsx52SPuRwRMzOlPz0EqGzsjgKRUyRAlaF4bFvXFt17idrJfaFwCMJDY=;24:OS5M+TgU6QQNiyH8i+hZPikrXgmdlj6b7ftfu+ht+NWE+lqphi2r718RscPuvz6mCwemkkGCOZOmx2Bxq9u6DgvlAcn4iEx3IF5Xo4QLC8Q=;7:bLIirIrPFd3u1A3ECCIrxFDVSyTZOIM79flj2LOUrPBRan20hb7SsP2XE6Vv7N2vYTchmRTFncWgiM6zz1f1rVkEYDXSKVanQyMebGKojTHpbePwtHZopUYXFL7sQtIPSRsEESIR5NRGxWN94NNlY0UBaHv53/4p1V/hzQMj0LCEQ89G89OGDb78o0EOrj8wbXMIT/TOs+Alx9rqQ95dNBYp4/+Pu618ELS2MJhn5iECnHRjVdYY0E2ef84ljs3e SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;20:UIvtU05gUNcbuxIftXQXhQqzIhMox9T31Th+Hnsee0uoRaBq+LUcRmHduTprMOV5XOzsKKkssB7kGANXGK43bIIh6qaJx+IU2SRco9uGsFiZ4m70gJHSV9cXzwTTGTOzTzaCCqt7+7F8Oi2+p3n7Q8dkBsInNlG/RozmkEcLPY5j4TJnc8J/JNYhPjNfj4iWJaf1JTc+nZs8RFY/0ap3X+lJT6Ev7QzgyPh/MZRwUh6lZxLjWZwEnmdJeBFLfUev X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2017 16:16:58.2131 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6eedbf87-0382-47ad-aaf5-08d52531cea5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/05/2017 05:34 AM, Borislav Petkov wrote: ... > > Fixes ontop: > > * !input.cert_chain_address test was repeated. I saw that by aligning > them vertically, i.e., after making it more readable, the repetition > became obvious. > > * Do the lengths checks first and the access_ok after, in each PDH and > cert chain test. > > * Do the checks first and the allocations after, not interleaved. > > * Comments are sentences which should end with a '.' > > (hunk below contains also that &psp_master->cmd_buf change but you're going to > remove that arg anyway). > I am good with all your fixup, I will apply them in v8. -Brijesh