From: Heiner Kallweit <hkallweit1@gmail.com>
To: Hayes Wang <hayeswang@realtek.com>, netdev@vger.kernel.org
Cc: nic_swsd@realtek.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152: modify rtl8152_set_speed function
Date: Mon, 2 Sep 2019 20:36:40 +0200 [thread overview]
Message-ID: <280e6a3d-c6c3-ef32-a65d-19566190a1d3@gmail.com> (raw)
In-Reply-To: <1394712342-15778-326-Taiwan-albertk@realtek.com>
On 02.09.2019 13:52, Hayes Wang wrote:
> First, for AUTONEG_DISABLE, we only need to modify MII_BMCR.
>
> Second, add advertising parameter for rtl8152_set_speed(). Add
> RTL_ADVERTISED_xxx for advertising parameter of rtl8152_set_speed().
> Then, the advertising settings from ethtool could be saved.
>
Seeing all this code it might be a good idea to switch this driver
to phylib, similar to what I did with r8169 some time ago.
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> ---
> drivers/net/usb/r8152.c | 196 +++++++++++++++++++++++++++-------------
> 1 file changed, 132 insertions(+), 64 deletions(-)
>
[...]
next prev parent reply other threads:[~2019-09-02 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 11:52 [PATCH net-next] r8152: modify rtl8152_set_speed function Hayes Wang
2019-09-02 18:36 ` Heiner Kallweit [this message]
2019-09-03 3:16 ` Hayes Wang
2019-09-03 6:13 ` Heiner Kallweit
2019-09-03 6:36 ` Hayes Wang
2019-09-03 6:44 ` Heiner Kallweit
2019-09-03 6:55 ` Hayes Wang
2019-09-03 7:12 ` Heiner Kallweit
2019-09-03 7:36 ` Hayes Wang
2019-09-04 22:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=280e6a3d-c6c3-ef32-a65d-19566190a1d3@gmail.com \
--to=hkallweit1@gmail.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).