From: Heiko Stuebner <heiko@sntech.de>
To: Shawn Lin <shawn.lin@kernel-upstream.org>
Cc: Caesar Wang <wxt@rock-chips.com>, Mark Brown <broonie@kernel.org>,
shawn.lin@rock-chips.com, Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036
Date: Fri, 20 May 2016 14:58:27 +0200 [thread overview]
Message-ID: <28155403.nCsUkeXQB1@phil> (raw)
In-Reply-To: <8f662b3b-e359-efdf-72e5-c4f862dd1cf6@kernel-upstream.org>
Am Freitag, 20. Mai 2016, 20:35:53 schrieb Shawn Lin:
> 在 2016/5/20 7:56, Caesar Wang 写道:
> > That's seem the incorrect string to match the spi driver.
>
> Will it break the backward compatibility for some dtb if not
> falling back to "rockchip,rockchip-spi" ?
in what dtb did you see "rockchip,rockchip-spi"?
I.e. it isn't part of any current _mainline_ devicetree files.
Heiko
>
> > Fixes commit f629fcfab2cd
> > ("ARM: dts: rockchip: support the spi for rk3036")
> >
> > Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> > Cc: Heiko Stuebner <heiko@sntech.de>
> > Cc: linux-rockchip@lists.infradead.org
> >
> > ---
> >
> > Changes in v2: None
> >
> > arch/arm/boot/dts/rk3036.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/rk3036.dtsi
> > b/arch/arm/boot/dts/rk3036.dtsi index d0f4bb7..a30700a 100644
> > --- a/arch/arm/boot/dts/rk3036.dtsi
> > +++ b/arch/arm/boot/dts/rk3036.dtsi
> > @@ -431,7 +431,7 @@
> >
> > };
> >
> > spi: spi@20074000 {
> >
> > - compatible = "rockchip,rockchip-spi";
> > + compatible = "rockchip,rk3036-spi";
> >
> > reg = <0x20074000 0x1000>;
> > interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > clocks =<&cru PCLK_SPI>, <&cru SCLK_SPI>;
next prev parent reply other threads:[~2016-05-20 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 23:56 [PATCH v2 1/3] spi/rockchip: add rk3036/rk3228/rk3368 SoCs for spi document Caesar Wang
2016-05-19 23:56 ` [PATCH v2 2/3] spi/rockchip: add the rk3036/rk3228/rk3368 to match for driver Caesar Wang
2016-05-19 23:56 ` [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 Caesar Wang
2016-05-20 12:35 ` Shawn Lin
2016-05-20 12:57 ` Caesar Wang
2016-05-20 13:04 ` Shawn Lin
2016-05-20 12:58 ` Heiko Stuebner [this message]
2016-05-20 13:09 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28155403.nCsUkeXQB1@phil \
--to=heiko@sntech.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@kernel-upstream.org \
--cc=shawn.lin@rock-chips.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).