From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337E9C33CA3 for ; Fri, 10 Jan 2020 11:13:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 106A320721 for ; Fri, 10 Jan 2020 11:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727803AbgAJLNb (ORCPT ); Fri, 10 Jan 2020 06:13:31 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:54139 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727733AbgAJLNb (ORCPT ); Fri, 10 Jan 2020 06:13:31 -0500 Received: from 79.184.255.90.ipv4.supernova.orange.pl (79.184.255.90) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.320) id 72f2d2c43d24f829; Fri, 10 Jan 2020 12:13:29 +0100 From: "Rafael J. Wysocki" To: Ikjoon Jang Cc: linux-pm@vger.kernel.org, "RafaelJ . Wysocki" , DanielLezcano , linux-kernel@vger.kernel.org Subject: Re: [PATCH] BUG-REPORT: cpuidle: teo: intervals[] array index out Date: Fri, 10 Jan 2020 12:13:28 +0100 Message-ID: <2821853.MfSkROXiEm@kreacher> In-Reply-To: <20200110015917.32825-1-ikjn@chromium.org> References: <20200110015917.32825-1-ikjn@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, January 10, 2020 2:59:17 AM CET Ikjoon Jang wrote: > This seems to be a simple bug in rotating array index. That's correct. Please repost the patch with a Signed-off-by tag, so I can apply it. > --- > drivers/cpuidle/governors/teo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpuidle/governors/teo.c b/drivers/cpuidle/governors/teo.c > index de7e706efd46..6deaaf5f05b5 100644 > --- a/drivers/cpuidle/governors/teo.c > +++ b/drivers/cpuidle/governors/teo.c > @@ -198,7 +198,7 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev) > * pattern detection. > */ > cpu_data->intervals[cpu_data->interval_idx++] = measured_ns; > - if (cpu_data->interval_idx > INTERVALS) > + if (cpu_data->interval_idx >= INTERVALS) > cpu_data->interval_idx = 0; > } > >