From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 506EFC4167B for ; Wed, 9 Dec 2020 20:24:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21AB923B99 for ; Wed, 9 Dec 2020 20:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387527AbgLIUYY (ORCPT ); Wed, 9 Dec 2020 15:24:24 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:58502 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730039AbgLIUYX (ORCPT ); Wed, 9 Dec 2020 15:24:23 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0B9KMYrS093383; Wed, 9 Dec 2020 14:22:34 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1607545354; bh=0YOr/KkSEFpTKDVBe5HkrfTXFveoPFaa5XWm7Svxg7A=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=nJBYIQZr0v6lufvH0ZaFAm1rXVXE8Y46IxZPkAIl62WLJ1VxUa2c66AtQB25EgYiV nL/a9qPUfn/JWmUpXk432xiAzXPWCSW+BNipBHHz1h0qVhdb2zU6coRwYG5Sla+gst JWg7Xk7Z6MfewE8yF3BpQi9dZr39egrZldmiauW0= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0B9KMYbu010807 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 9 Dec 2020 14:22:34 -0600 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 9 Dec 2020 14:22:34 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 9 Dec 2020 14:22:34 -0600 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0B9KMTT1020549; Wed, 9 Dec 2020 14:22:31 -0600 Subject: Re: Howto listen to/handle gpio state changes ? Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver To: Linus Walleij , Arnd Bergmann CC: "Enrico Weigelt, metux IT consult" , "Michael S. Tsirkin" , Jason Wang , Jonathan Corbet , Linux Doc Mailing List , "linux-kernel@vger.kernel.org" , , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , linux-riscv , "Enrico Weigelt, metux IT consult" References: <20201203191135.21576-1-info@metux.net> <20201203191135.21576-2-info@metux.net> <0080d492-2f07-d1c6-d18c-73d4204a5d40@metux.net> <51d3efb7-b7eb-83d7-673a-308dd51616d3@metux.net> From: Grygorii Strashko Message-ID: <2827855a-dc4f-2e17-aca3-4b1b9f0d5084@ti.com> Date: Wed, 9 Dec 2020 22:22:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2020 14:53, Linus Walleij wrote: > On Wed, Dec 9, 2020 at 12:19 PM Arnd Bergmann wrote: >> On Wed, Dec 9, 2020 at 9:51 AM Linus Walleij wrote: >>> On Tue, Dec 8, 2020 at 3:07 PM Enrico Weigelt, metux IT consult wrote: >> >>> What we need to understand is if your new usecase is an outlier >>> so it is simplest modeled by a "mock" irq_chip or we have to design >>> something new altogether like notifications on changes. I suspect >>> irq_chip would be best because all drivers using GPIOs for interrupts >>> are expecting interrupts, and it would be an enormous task to >>> change them all and really annoying to create a new mechanism >>> on the side. >> >> I would expect the platform abstraction to actually be close enough >> to a chained irqchip that it actually works: the notification should >> come in via vring_interrupt(), which is a normal interrupt handler >> that calls vq->vq.callback(), calling generic_handle_irq() (and >> possibly chained_irq_enter()/chained_irq_exit() around it) like the >> other gpio drivers do should just work here I think, and if it did >> not, then I would expect this to be just a bug in the driver rather >> than something missing in the gpio framework. > > Performance/latency-wise that would also be strongly encouraged. > > Tglx isn't super-happy about the chained interrupts at times, as they > can create really nasty bugs, but a pure IRQ in fastpath of some > kinde is preferable and intuitive either way. In my opinion the problem here is that proposed patch somehow describes Front end, but says nothing about Backend and overall design. What is expected to be virtualized? whole GPIO chip? or set of GPIOs from different GPIO chips? Most often nobody want to give Guest access to the whole GPIO chip, so, most probably, smth. similar to GPIO Aggregator will be needed. How is situation going to be resolved that GPIO framework and IRQ framework are independent, but intersect, and GPIO controller drivers have no idea who and how requesting GPIO IRQ - threaded vs non-threaded vs oneshot. So, some information need to be transferred to Back end - at minimum IRQ triggering type. Overall, it might be better to start from pure gpio and leave GPIO IRQ aside. -- Best regards, grygorii