From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89415C388F7 for ; Wed, 4 Nov 2020 10:32:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2762421734 for ; Wed, 4 Nov 2020 10:32:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="IYCeT5jY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729059AbgKDKcE (ORCPT ); Wed, 4 Nov 2020 05:32:04 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:49768 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729301AbgKDKab (ORCPT ); Wed, 4 Nov 2020 05:30:31 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604485830; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=GsO/kwxUnYZ25pfIe9ieoDTOJZIDA3Es7kSsa/cs0s0=; b=IYCeT5jYbc5/05/6Dhhiz6C/g1AYQmlhnjm10wz6ABfRPdF5vk9JBUn4GJmc+bt/aqxGCEPW avoNWTxfD6+PmpLVNQqY/Kt2JBA0BR1G0eBNUy/yEINaxP/JOlsHDcV+cNeqiHyRWu7wJY9W zeOzZFxUW6FXdu8HsedeLttvFoQ= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 5fa2828b978460d05b7b58ae (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 04 Nov 2020 10:29:31 GMT Sender: vjitta=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 36540C433F0; Wed, 4 Nov 2020 10:29:31 +0000 (UTC) Received: from [192.168.0.104] (unknown [106.0.37.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vjitta) by smtp.codeaurora.org (Postfix) with ESMTPSA id 49E2EC433C6; Wed, 4 Nov 2020 10:29:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 49E2EC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=vjitta@codeaurora.org Subject: Re: [PATCH] lib: stackdepot: Add support to configure STACK_HASH_SIZE To: Minchan Kim , linux-mm Cc: glider@google.com, Dan Williams , broonie@kernel.org, mhiramat@kernel.org, "linux-kernel@vger.kernel.org" , Andrew Morton , Yogesh Lal , Vinayak Menon References: <1603372546-27118-1-git-send-email-vjitta@codeaurora.org> From: Vijayanand Jitta Message-ID: <282d7028-498d-50b3-37d4-2381571f9f9e@codeaurora.org> Date: Wed, 4 Nov 2020 15:59:16 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/4/2020 4:57 AM, Minchan Kim wrote: > Sorry if this mail corrupts the mail thread or had heavy mangling > since I lost this mail from my mailbox so I am sending this mail by > web gmail. > > On Thu, Oct 22, 2020 at 10:18 AM wrote: >> >> From: Yogesh Lal >> >> Use STACK_HASH_ORDER_SHIFT to configure STACK_HASH_SIZE. >> >> Aim is to have configurable value for STACK_HASH_SIZE, >> so depend on use case one can configure it. >> >> One example is of Page Owner, default value of >> STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. >> Making it configurable and use lower value helps to enable features like >> CONFIG_PAGE_OWNER without any significant overhead. >> >> Signed-off-by: Yogesh Lal >> Signed-off-by: Vinayak Menon >> Signed-off-by: Vijayanand Jitta >> --- >> lib/Kconfig | 9 +++++++++ >> lib/stackdepot.c | 3 +-- >> 2 files changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/lib/Kconfig b/lib/Kconfig >> index 18d76b6..b3f8259 100644 >> --- a/lib/Kconfig >> +++ b/lib/Kconfig >> @@ -651,6 +651,15 @@ config STACKDEPOT >> bool >> select STACKTRACE >> >> +config STACK_HASH_ORDER_SHIFT >> + int "stack depot hash size (12 => 4KB, 20 => 1024KB)" >> + range 12 20 >> + default 20 >> + depends on STACKDEPOT >> + help >> + Select the hash size as a power of 2 for the stackdepot hash table. >> + Choose a lower value to reduce the memory impact. >> + >> config SBITMAP >> bool >> >> diff --git a/lib/stackdepot.c b/lib/stackdepot.c >> index 2caffc6..413c20b 100644 >> --- a/lib/stackdepot.c >> +++ b/lib/stackdepot.c >> @@ -142,8 +142,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size, >> return stack; >> } >> >> -#define STACK_HASH_ORDER 20 >> -#define STACK_HASH_SIZE (1L << STACK_HASH_ORDER) >> +#define STACK_HASH_SIZE (1L << CONFIG_STACK_HASH_ORDER_SHIFT) >> #define STACK_HASH_MASK (STACK_HASH_SIZE - 1) >> #define STACK_HASH_SEED 0x9747b28c >> >> -- >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation >> 2.7.4 >> > > 1. When we don't use page_owner, we don't want to waste any memory for > stackdepot hash array. > 2. When we use page_owner, we want to have reasonable stackdeport hash array > > With this configuration, it couldn't meet since we always need to > reserve a reasonable size for the array. > Can't we make the hash size as a kernel parameter? > With it, we could use it like this. > > 1. page_owner=off, stackdepot_stack_hash=0 -> no more wasted memory > when we don't use page_owner > 2. page_owner=on, stackdepot_stack_hash=8M -> reasonable hash size > when we use page_owner. > > This idea looks fine to me. Andrew and others would like to hear your comments as well on this before implementing. Thanks, Vijay -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation