From: Kishon Vijay Abraham I <kishon@ti.com>
To: Vivek Gautam <vivek.gautam@codeaurora.org>,
Can Guo <cang@codeaurora.org>
Cc: Subhash Jadavani <subhashj@codeaurora.org>,
<asutoshd@codeaurora.org>, <evgreen@chromium.org>,
Manu Gautam <mgautam@codeaurora.org>,
robh+dt <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v10 0/6] Support for Qualcomm UFS QMP PHY on SDM845
Date: Fri, 7 Dec 2018 10:01:43 +0530 [thread overview]
Message-ID: <2835270c-79aa-81fc-574a-5cb48a542260@ti.com> (raw)
In-Reply-To: <CAFp+6iH9sz3NsejvxLdgAy+E-6Rff9RDA74EtnSidWOuZN=q9w@mail.gmail.com>
Hi,
On 05/12/18 12:31 PM, Vivek Gautam wrote:
> On Tue, Oct 23, 2018 at 10:07 AM Can Guo <cang@codeaurora.org> wrote:
>>
>> This patch series adds support for UFS QMP PHY on SDM845 and the
>> compatible string for it. This patch series depends on the current
>> proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on
>> the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also
>> rebased on updated pipe_clk initialization sequence [3]. This series
>> can only be merged once the dependent patches do.
>> [1] http://lists-archives.com/linux-kernel/29071659-dt-bindings-phy-qcom-qmp-update-bindings-for-sdm845.html
>> [2] http://lists-archives.com/linux-kernel/29071660-phy-qcom-qmp-add-qmp-v3-usb3-uni-phy-support-for-sdm845.html
>> [3] https://patchwork.kernel.org/patch/10376551/
>
> Besides my comment for PATCH 4/6, I have already reviewed the entire series,
> and it looks good.
> If adding new bindings for sdm845 needs a further review, can you separate out
> just the phy patches from this series (patch 1, 2, 3 & 6), and re-send them.
> We can ask Kishon if he can pull them in for this merge window.
> Thanks.
Looks like the PHY patches has gone in the previous merge window itself. If
there are any changes, please post only the diff as a separate patch.
Thanks
Kishon
>
> best regards
> Vivek
>
>>
>> Changes since v9:
>> - Incorporated review comments from Rob.
>>
>> Changes since v8:
>> - Add one new change to support ufs core reset.
>> - Incorporated review comments from Evan, Vivek.
>>
>> Changes since v7:
>> - Add one new change to update UFS PHY power on sequence
>> - Incorporated review comments from Evan, Vivek and Manu.
>>
>> Changes since v6:
>> - Add one new change to clean up some structs and field
>> - Updates the PHY power control sequence.
>> - Incorporated review comments from Vivek and Manu.
>>
>> Changes since v5:
>> - Updates the PHY power control sequence.
>> - Updates UFS PHY power on condition check.
>>
>> Changes since v4:
>> - Adds 'ref_aux' clock back to SDM845 UFS PHY clock list.
>> - Power on PHY before serdes configuration starts.
>> - Updates the UFS PHY initialization sequence.
>> - Updates a few UFS PHY registers.
>> - Incorporated review comments from Vivek and Manu.
>>
>> Changes since v3:
>> - Incorporated review comments from Vivek and Rob.
>>
>> Changes since v2:
>> - Incorporated review comments from Vivek and Rob.
>> - Remove "ref_aux" from sdm845 ufs phy clock list structure.
>>
>> Changes since v1:
>> - Incorporated review comments from Vivek and Manu.
>> - Update the commit title of patch 2.
>>
>> Can Guo (5):
>> phy: Update PHY power control sequence
>> phy: General struct and field cleanup
>> phy: Add QMP phy based UFS phy support for sdm845
>> scsi: ufs: Power on phy after it is initialized
>> dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845
>>
>> Dov Levenglick (1):
>> scsi: ufs: Add core reset support
>>
>> .../devicetree/bindings/phy/qcom-qmp-phy.txt | 4 +-
>> drivers/phy/qualcomm/phy-qcom-qmp.c | 216 +++++++++++++++++++--
>> drivers/phy/qualcomm/phy-qcom-qmp.h | 15 ++
>> drivers/scsi/ufs/ufs-qcom.c | 34 +++-
>> drivers/scsi/ufs/ufs-qcom.h | 1 +
>> drivers/scsi/ufs/ufshcd-pltfrm.c | 22 +++
>> drivers/scsi/ufs/ufshcd.c | 13 ++
>> drivers/scsi/ufs/ufshcd.h | 12 ++
>> 8 files changed, 296 insertions(+), 21 deletions(-)
>>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
>
>
prev parent reply other threads:[~2018-12-07 4:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 4:35 [PATCH v10 0/6] Support for Qualcomm UFS QMP PHY on SDM845 Can Guo
2018-10-23 4:35 ` [PATCH v10 1/6] phy: Update PHY power control sequence Can Guo
2018-10-23 4:35 ` [PATCH v10 2/6] phy: General struct and field cleanup Can Guo
2018-10-23 4:35 ` [PATCH v10 3/6] phy: Add QMP phy based UFS phy support for sdm845 Can Guo
2018-10-23 4:35 ` [PATCH v10 4/6] scsi: ufs: Add core reset support Can Guo
2018-12-05 6:07 ` Vivek Gautam
2018-10-23 4:36 ` [PATCH v10 5/6] scsi: ufs: Power on phy after it is initialized Can Guo
2018-10-23 4:36 ` [PATCH v10 6/6] dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845 Can Guo
2018-12-05 7:01 ` [PATCH v10 0/6] Support for Qualcomm UFS QMP PHY on SDM845 Vivek Gautam
2018-12-07 4:31 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2835270c-79aa-81fc-574a-5cb48a542260@ti.com \
--to=kishon@ti.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=subhashj@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).