From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1041090AbdDUObP (ORCPT ); Fri, 21 Apr 2017 10:31:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41678 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1040038AbdDUObL (ORCPT ); Fri, 21 Apr 2017 10:31:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5656F3C88C3 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5656F3C88C3 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170421083037.12746-4-ebiggers3@gmail.com> References: <20170421083037.12746-4-ebiggers3@gmail.com> <20170421083037.12746-1-ebiggers3@gmail.com> To: Eric Biggers Cc: dhowells@redhat.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers , Mimi Zohar , David Safford Subject: Re: [PATCH 3/5] KEYS: encrypted: sanitize all key material MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28372.1492785068.1@warthog.procyon.org.uk> Date: Fri, 21 Apr 2017 15:31:08 +0100 Message-ID: <28373.1492785068@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 21 Apr 2017 14:31:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Biggers wrote: > - memzero_explicit(epayload->decrypted_data, epayload->decrypted_datalen); > - kfree(key->payload.data[0]); > + kzfree(key->payload.data[0]); Should kzfree() be using memzero_explicit() rather than memset()? David