From: Jeremy Linton <jeremy.linton@arm.com>
To: Pierre Gondois <pierre.gondois@arm.com>, linux-kernel@vger.kernel.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gavin Shan <gshan@redhat.com>, Peter Chen <peter.chen@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 3/5] ACPI: PPTT: Remove acpi_find_cache_levels()
Date: Thu, 10 Nov 2022 17:17:50 -0600 [thread overview]
Message-ID: <285274e0-51bd-3334-1cb2-3af1b1aa1ba2@arm.com> (raw)
In-Reply-To: <20221108110424.166896-4-pierre.gondois@arm.com>
On 11/8/22 05:04, Pierre Gondois wrote:
> acpi_find_cache_levels() is used at a single place and is short
> enough to be merged into the calling function. The removal allows
> an easier renaming of the calling function in the next patch.
>
> Also reorder the parameters in the 'reversed Christmas tree' order.
>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
This bit looks fine too:
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
> drivers/acpi/pptt.c | 21 ++++++---------------
> 1 file changed, 6 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c
> index c91342dcbcd6..97c1d33822d1 100644
> --- a/drivers/acpi/pptt.c
> +++ b/drivers/acpi/pptt.c
> @@ -281,19 +281,6 @@ static struct acpi_pptt_processor *acpi_find_processor_node(struct acpi_table_he
> return NULL;
> }
>
> -static int acpi_find_cache_levels(struct acpi_table_header *table_hdr,
> - u32 acpi_cpu_id)
> -{
> - int number_of_levels = 0;
> - struct acpi_pptt_processor *cpu;
> -
> - cpu = acpi_find_processor_node(table_hdr, acpi_cpu_id);
> - if (cpu)
> - number_of_levels = acpi_count_levels(table_hdr, cpu);
> -
> - return number_of_levels;
> -}
> -
> static u8 acpi_cache_type(enum cache_type type)
> {
> switch (type) {
> @@ -613,9 +600,10 @@ static int check_acpi_cpu_flag(unsigned int cpu, int rev, u32 flag)
> */
> int acpi_find_last_cache_level(unsigned int cpu)
> {
> - u32 acpi_cpu_id;
> + struct acpi_pptt_processor *cpu_node;
> struct acpi_table_header *table;
> int number_of_levels = 0;
> + u32 acpi_cpu_id;
>
> table = acpi_get_pptt();
> if (!table)
> @@ -624,7 +612,10 @@ int acpi_find_last_cache_level(unsigned int cpu)
> pr_debug("Cache Setup find last level CPU=%d\n", cpu);
>
> acpi_cpu_id = get_acpi_id_for_cpu(cpu);
> - number_of_levels = acpi_find_cache_levels(table, acpi_cpu_id);
> + cpu_node = acpi_find_processor_node(table, acpi_cpu_id);
> + if (cpu_node)
> + number_of_levels = acpi_count_levels(table, cpu_node);
> +
> pr_debug("Cache Setup find last level level=%d\n", number_of_levels);
>
> return number_of_levels;
next prev parent reply other threads:[~2022-11-10 23:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 11:04 [PATCH 0/5] arch_topology: Build cacheinfo from primary CPU Pierre Gondois
2022-11-08 11:04 ` [PATCH 1/5] cacheinfo: Use riscv's init_cache_level() as generic OF implem Pierre Gondois
2022-11-08 14:07 ` Conor Dooley
2022-11-08 15:59 ` Sudeep Holla
2022-11-08 17:21 ` Conor Dooley
2022-11-08 16:03 ` Sudeep Holla
2022-11-08 16:08 ` Sudeep Holla
2022-11-08 11:04 ` [PATCH 2/5] cacheinfo: Return error code in init_of_cache_level() Pierre Gondois
2022-11-08 16:05 ` Sudeep Holla
2022-11-08 11:04 ` [PATCH 3/5] ACPI: PPTT: Remove acpi_find_cache_levels() Pierre Gondois
2022-11-08 16:13 ` Sudeep Holla
2022-11-08 16:56 ` Pierre Gondois
2022-11-10 23:17 ` Jeremy Linton [this message]
2022-11-08 11:04 ` [PATCH 4/5] ACPI: PPTT: Update acpi_find_last_cache_level() to acpi_get_cache_info() Pierre Gondois
2022-11-10 23:13 ` Jeremy Linton
2022-11-08 11:04 ` [PATCH 5/5] arch_topology: Build cacheinfo from primary CPU Pierre Gondois
2022-11-08 17:17 ` kernel test robot
2022-11-08 11:11 ` [PATCH 0/5] " Pierre Gondois
2022-11-08 14:04 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=285274e0-51bd-3334-1cb2-3af1b1aa1ba2@arm.com \
--to=jeremy.linton@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peter.chen@kernel.org \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).