From: Dmitry Osipenko <digetx@gmail.com>
To: Jiada Wang <jiada_wang@mentor.com>,
dmitry.torokhov@gmail.com, robh+dt@kernel.org,
thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: nick@shmanahar.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
erosca@de.adit-jv.com, andrew_gabbasov@mentor.com
Subject: Re: [PATCH v2 2/3] Input: atmel_mxt_ts - implement I2C retries for mXT1368
Date: Sat, 26 Sep 2020 00:01:25 +0300 [thread overview]
Message-ID: <285f5b25-820c-4402-0ebf-5bac87c95d84@gmail.com> (raw)
In-Reply-To: <20200925135257.21138-3-jiada_wang@mentor.com>
25.09.2020 16:52, Jiada Wang пишет:
> According to datasheet, mXT1386 chip has a WAKE line, it is used
> to wake the chip up from deep sleep mode before communicating with
> it via the I2C-compatible interface.
>
> if the WAKE line is connected to a GPIO line, the line must be
> asserted 25 ms before the host attempts to communicate with the mXT1386.
> If the WAKE line is connected to the SCL pin, the mXT1386 will send a
> NACK on the first attempt to address it, the host must then retry 25 ms
> later.
>
> This patch adds compatible string "atmel,mXT1386" for mXT1386 controller,
> when I2C transfer on mXT1386 fails, retry the transfer once after a 25 ms
> sleep.
>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 62 +++++++++++++++++++-----
> 1 file changed, 50 insertions(+), 12 deletions(-)
Hello, Jiada! Thank you very much!
Will be nice if this patch could land to v5.10 :)
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2020-09-25 21:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 13:52 [PATCH v2 0/3] implement I2C retries for mXT1368 Jiada Wang
2020-09-25 13:52 ` [PATCH v2 1/3] dt-bindings: input: atmel: add compatible for mXT1386 Jiada Wang
2020-09-25 21:01 ` Dmitry Osipenko
2020-09-28 6:59 ` Thierry Reding
2020-09-30 14:22 ` Wang, Jiada
2020-09-25 13:52 ` [PATCH v2 2/3] Input: atmel_mxt_ts - implement I2C retries for mXT1368 Jiada Wang
2020-09-25 21:01 ` Dmitry Osipenko [this message]
2020-09-25 13:52 ` [PATCH v2 3/3] ARM: tegra: add mXT1386 compatible Jiada Wang
2020-09-25 21:02 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=285f5b25-820c-4402-0ebf-5bac87c95d84@gmail.com \
--to=digetx@gmail.com \
--cc=andrew_gabbasov@mentor.com \
--cc=dmitry.torokhov@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=jiada_wang@mentor.com \
--cc=jonathanh@nvidia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nick@shmanahar.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).