From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 438C9C83013 for ; Tue, 1 Dec 2020 17:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB1A32076C for ; Tue, 1 Dec 2020 17:20:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QZiQ5dHb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731118AbgLARUW (ORCPT ); Tue, 1 Dec 2020 12:20:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59641 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731081AbgLARUV (ORCPT ); Tue, 1 Dec 2020 12:20:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606843134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vydv8w43cnFgjfkZU3nZrnMx51U7DpJsIR+Fxa/fu3g=; b=QZiQ5dHbF7+lqz+hTqPBwNuK0wG+Ige/n2ZpBD/3QN3Qp9rWcQdyRBbNWnK3dbEJGLzzWo 5u8S5ZUhs70to3AsT3w1voVShAzBXsPItZYK/bPTkSA1uom8+c2+TV5oImxd8r9+lecId7 lAcrseo3/QKpIELbCfbJ6h0GBX20bxQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-hKil68X3Mi2a70ALDMAQxw-1; Tue, 01 Dec 2020 12:18:51 -0500 X-MC-Unique: hKil68X3Mi2a70ALDMAQxw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 339351005E45; Tue, 1 Dec 2020 17:18:50 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-159.rdu2.redhat.com [10.10.112.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id 510DE60854; Tue, 1 Dec 2020 17:18:45 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <7027520f-7c79-087e-1d00-743bdefa1a1e@redhat.com> References: <7027520f-7c79-087e-1d00-743bdefa1a1e@redhat.com> To: Eric Sandeen Cc: dhowells@redhat.com, torvalds@linux-foundation.org, Miklos Szeredi , Ira Weiny , linux-fsdevel@vger.kernel.org, linux-man@vger.kernel.org, linux-kernel@vger.kernel.org, xfs , linux-ext4@vger.kernel.org, Xiaoli Feng Subject: Re: [PATCH 1/2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <286419.1606843124.1@warthog.procyon.org.uk> Date: Tue, 01 Dec 2020 17:18:44 +0000 Message-ID: <286420.1606843124@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Sandeen wrote: > STATX_ATTR_MOUNT_ROOT and STATX_ATTR_DAX got merged with the same value, > so one of them needs fixing. Move STATX_ATTR_DAX. > > While we're in here, clarify the value-matching scheme for some of the > attributes, and explain why the value for DAX does not match. > > Signed-off-by: Eric Sandeen You should probably have one or two Fixes: lines in it. It might be worth referencing both of the patches that added conflicting bits. Fixes: 80340fe3605c ("statx: add mount_root") Fixes: 712b2698e4c0 ("fs/stat: Define DAX statx attribute") It should probably have: Reported-by: David Howells also as you mentioned that in the cover. You can also add: Reviewed-by: David Howells David