From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752465AbdKUDcJ (ORCPT ); Mon, 20 Nov 2017 22:32:09 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:32858 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbdKUDcH (ORCPT ); Mon, 20 Nov 2017 22:32:07 -0500 X-Google-Smtp-Source: AGs4zMYjznLrC8F2VIr3C/QLWtRoEwDbMhP0L3UEbxHVcvLjvUxQwqhgQIpvC4Osrx4E31IkHm4mjw== Subject: Re: [PATCH] MIPS: Fix CPS SMP NS16550 UART defaults To: James Hogan , Ralf Baechle Cc: Paul Burton , linux-kernel@vger.kernel.org, James Hogan , linux-mips@linux-mips.org References: <5e88e3d4-3c4b-b5eb-0b32-d0c0902e14c2@roeck-us.net> <20171121000240.4058-1-james.hogan@mips.com> From: Guenter Roeck Message-ID: <286daa85-6bae-939a-a2a4-53ec08b7c340@roeck-us.net> Date: Mon, 20 Nov 2017 19:32:05 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171121000240.4058-1-james.hogan@mips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/2017 04:02 PM, James Hogan wrote: > From: James Hogan > > The MIPS_CPS_NS16550_BASE and MIPS_CPS_NS16550_SHIFT options have no > defaults for non-Malta platforms which select SYS_SUPPORTS_MIPS_CPS > (i.e. the pistachio and generic platforms). This is problematic for > automated allyesconfig and allmodconfig builds based on these platforms, > since make silentoldconfig tries to ask the user for values, and > especially since v4.15 where the default platform was switched to > generic. > > Default these options to 0 and arrange for MIPS_CPS_NS16550 to be no > when using that default base address, so that the option only has an > effect when the default is provided (i.e. Malta) or when a value is > provided by the user. > > Fixes: 609cf6f2291a ("MIPS: CPS: Early debug using an ns16550-compatible UART") > Signed-off-by: James Hogan > Reviewed-by: Paul Burton > Cc: Ralf Baechle > Cc: Guenter Roeck > Cc: linux-mips@linux-mips.org > --- > Guenter: I'm guessing this is the problem you're referring to. Yes. Tested-by: Guenter Roeck mips:allmodconfig still fails to build with this patch applied, but elsewhere. In file included from /opt/buildbot/slave/hwmon-testing/build/include/linux/bcma/bcma.h:10:0, from /opt/buildbot/slave/hwmon-testing/build/drivers/bcma/bcma_private.h:9, from /opt/buildbot/slave/hwmon-testing/build/drivers/bcma/main.c:8: /opt/buildbot/slave/hwmon-testing/build/include/linux/bcma/bcma_driver_pci.h:218:24: error: field 'pci_controller' has incomplete type Guenter