From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966305AbdAKMy6 (ORCPT ); Wed, 11 Jan 2017 07:54:58 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:59033 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966244AbdAKMy4 (ORCPT ); Wed, 11 Jan 2017 07:54:56 -0500 X-AuditID: b6c32a58-f79946d000005960-0a-58762b1d88b7 From: Bartlomiej Zolnierkiewicz To: Kees Cook Cc: Sudip Mukherjee , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] video: fbdev: matroxfb: use designated initializers Date: Wed, 11 Jan 2017 13:54:46 +0100 Message-id: <2879252.YjYsoy7Sv0@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170103232433.GA117659@beast> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42LZdlhTXVdWuyzCYOEMWYsz3bkWJ/o+sFpc 3jWHzeLA6SnMFuvn32JzYPWY3XCRxWPnrLvsHsdvbGfy+LxJLoAlissmJTUnsyy1SN8ugSvj 5Z9+5oL5QhXvTvQxNjCu4e9i5OSQEDCROHCgkxnCFpO4cG89WxcjF4eQwFJGiYutm1ghnHYm id9XzrDBdHxffooRIjGHUeLd9qNQLV8ZJVZcf88IUsUmYCUxsX0VmC0ioCrx/VIz2A5mgemM Ep++54LYwgLeEg8XbAaLswDVTF/4lAnE5hXQlJh98SPYNlEBL4kt+9rB4pwCOhK7zhxih6gR lPgx+R4LxEx5iX37p7JC2DoSZ4+tA7tOQqCbXWJpRzNQAweQIyux6QDUny4S/Yf+MkLYwhKv jm9hh7ClJf4uvQUVB7pz+28JiDmbGSVW7Z4AVWQtcfj4RahlfBK9v58wQcznlehoE4Io8ZCY s+MhVLmjxMzpB8DuFBKol/g3u4N5AqP8LCQvzELywiwkLyxgZF7FKJZaUJybnlpsWmCiV5yY W1yal66XnJ+7iRGcNLQidjD+mxF0iFGAg1GJh/fBi5IIIdbEsuLK3EOMEhzMSiK8L9TLIoR4 UxIrq1KL8uOLSnNSiw8xSnOwKInzLqiwjhASSE8sSc1OTS1ILYLJMnFwSjUwrj4307xk7bHY Qz5WE0813ivu+P/2prjqumOTrxb9tK6VuSj17ITCWgPf6GW73ypx2f28q7WJj+/e6j6N/OSO jZcY27OU+rUfCXzQW8iyxWJHXf/+U092CkwqCOTYfCDGetfq85L27GtXGG1WFPpU5Pc19/IX NYXVJx9ma/+4uP6osPWGVa+FNyixFGckGmoxFxUnAgBpJiq+FgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsVy+t9jQV1Z7bIIg42TBSzOdOdanOj7wGpx edccNosDp6cwW6yff4vNgdVjdsNFFo+ds+6yexy/sZ3J4/MmuQCWKDebjNTElNQihdS85PyU zLx0W6XQEDddCyWFvMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nbJbhlvPzTz1wwX6ji 3Yk+xgbGNfxdjJwcEgImEt+Xn2KEsMUkLtxbzwZiCwnMYpTo/i3RxcgFZH9llDj78AgTSIJN wEpiYvsqsAYRAVWJ75eamUGKmAWmM0p8eHmeGSQhLOAt8XDBZjCbBaho+sKnYM28ApoSsy9+ BNsgKuAlsWVfO1icU0BHYteZQ+wQm7Ul1txvYIaoF5T4MfkeC4jNLCAvsW//VFYIW0ti/c7j TBMYgc5EKJuFpGwWkrIFjMyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYKj6Jn0DsbD u9wPMQpwMCrx8L54XxIhxJpYVlyZe4hRgoNZSYT3hXpZhBBvSmJlVWpRfnxRaU5q8SFGU6AH JzJLiSbnAyM8ryTe0MTcxNzYwMLc0tLESEmct3H2s3AhgfTEktTs1NSC1CKYPiYOTqkGxszj Jj4d3/4xbdnJ3WtsubXexVXc0nrTla0bq8VPf9pVYt0YrnlYau7SNRP75t3TVl6RV/vuf0+W e9DqtTanwnKDhHS0C19xO6d3RLCv71ENvrL2YPPnxnxfibfCK1feczt6Zsli8eiDudX7fVMi mPY1vBRadcXy8v3zv7/tKlXMiG3QWFT+UImlOCPRUIu5qDgRAHuUd/e4AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111125453epcas5p3b7a3a3aecbeac551a9d99e26d1024ccc X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170111125453epcas5p3b7a3a3aecbeac551a9d99e26d1024ccc X-RootMTR: 20170111125453epcas5p3b7a3a3aecbeac551a9d99e26d1024ccc References: <20170103232433.GA117659@beast> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, January 03, 2017 03:24:33 PM Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook Thanks, queued for 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/matrox/matroxfb_DAC1064.c | 10 ++++++++-- > drivers/video/fbdev/matrox/matroxfb_Ti3026.c | 5 ++++- > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > index a01147fdf270..b380a393cbc3 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > +++ b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > @@ -1088,14 +1088,20 @@ static void MGAG100_restore(struct matrox_fb_info *minfo) > > #ifdef CONFIG_FB_MATROX_MYSTIQUE > struct matrox_switch matrox_mystique = { > - MGA1064_preinit, MGA1064_reset, MGA1064_init, MGA1064_restore, > + .preinit = MGA1064_preinit, > + .reset = MGA1064_reset, > + .init = MGA1064_init, > + .restore = MGA1064_restore, > }; > EXPORT_SYMBOL(matrox_mystique); > #endif > > #ifdef CONFIG_FB_MATROX_G > struct matrox_switch matrox_G100 = { > - MGAG100_preinit, MGAG100_reset, MGAG100_init, MGAG100_restore, > + .preinit = MGAG100_preinit, > + .reset = MGAG100_reset, > + .init = MGAG100_init, > + .restore = MGAG100_restore, > }; > EXPORT_SYMBOL(matrox_G100); > #endif > diff --git a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > index 68fa037d8cbc..9ff9be85759e 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > +++ b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > @@ -738,7 +738,10 @@ static int Ti3026_preinit(struct matrox_fb_info *minfo) > } > > struct matrox_switch matrox_millennium = { > - Ti3026_preinit, Ti3026_reset, Ti3026_init, Ti3026_restore > + .preinit = Ti3026_preinit, > + .reset = Ti3026_reset, > + .init = Ti3026_init, > + .restore = Ti3026_restore > }; > EXPORT_SYMBOL(matrox_millennium); > #endif