From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbdK1KRD (ORCPT ); Tue, 28 Nov 2017 05:17:03 -0500 Received: from mout.web.de ([212.227.15.4]:62400 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248AbdK1KQ5 (ORCPT ); Tue, 28 Nov 2017 05:16:57 -0500 Subject: Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions To: Julia Lawall , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Joe Perches , "Andrew F. Davis" , Arvind Yadav , Bartlomiej Zolnierkiewicz , Tomi Valkeinen , LKML , kernel-janitors@vger.kernel.org References: <1511809633.32426.70.camel@perches.com> <1511833514.32426.86.camel@perches.com> <7e7e64cf-dbe5-614a-f1e5-29d7b6cf9297@users.sourceforge.net> <1511856244.19952.14.camel@perches.com> <0ecf4b17-7757-adb4-b978-a80ebb15cfe6@users.sourceforge.net> From: SF Markus Elfring Message-ID: <28816ce9-9d62-7d61-1889-64407eececca@users.sourceforge.net> Date: Tue, 28 Nov 2017 11:15:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:K/f5Gj6E03Al+fGSL8RWOoxf8X4ys/7o4r/Cnv18ruWKxkdxLV2 j8mBKBQE+20eNo1idBgw6iBB4tSYT2VjGwPiL31ETZyFaT0JYRPK0i8CBy0Sdfk2wygG7mI UzsH2EsYNS3+u1rvleU9dQdDU3Y2bczT5KgVAdqUeJNRuTfwQhjGaHz8+jOJ5oUS9O+ZeUp FxSwdcFL3O3cWJzn2LqBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:pL9jFRrcvAA=:I1G2fJCEPqujI5+xUmlshT DmKeu7KEqaHAwNddrUUGa3l9INSyxbf4xGkFgBcRXIFrXoAJMP3N7deCIzRBvit6e428zdLmk 2FRGCHn84xVzSnvbedtb55EOq6R4VLXbK7icZsl5AQOTOF6ealuV5z55ZdYdD3sXwGw7fnlQs CyFsljXGufTTIksmGoi6d6n7YAG9aYMu3gox0MvLV0C8orE2f3Akafs2b30SaHIj+W9Bgs2nD 5L/NE4eBd/SlvhWcHKodI/I1iUwDdYknq+4CETPBwd9TqMmRUxe0XZ/DKIa3hLU9qFbI761t8 1EvtMoHpx8IwRYLwFlw/SW8OkCqFeSj7dbZqK9H7Xeq7nmedJO1Dc+SmGXQrazCUZ0lpjJm5O 7ET63y1PpHB7JyFK0iFVMIoMj003a3YELzfXkSMeCBgh0A8yiDqItw9i/SgGBut40AS7yURwL I8LMsMP48fOg+FTBOZf2ndu1K68T8n9E9CjT0uKdrLWEmCsNlt14cLPCa1DiIf5/D8IgWkv35 nn3C+FTGDJuiH5MzgIhO2fCjW4pHRz07fMoe8xUnARywmoE6ubBoKUC3jXEOTld1PT3wRE3qM PLut4B7POWo1UhDtmGGDu3ZANVQ5pODGPWc0US+3oqYwIYwGffox5A3a4f2md1w+SZL1fNst3 AKEkr3oNy6tUEob1v8sPgtz+ghYBFruJJOP9h/bdwN0m2EvnM2RdXZOm4ALxxcHxOKA0xmBzc U6njhq6Yv3gnsEu19xjczLiVeheJBDVOGvRvssjNJvHGU7ls3SVNdozk1whBfDiP/2WEalPDq IpWuPnduX3N4dQG7zOHimAMsiXFY0L9gPAliF6Rn5zGWISJYkY/GzyessgnhAo3j08FvUKA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> Many people do not know that a generic kmalloc does a >>> dump_stack() on OOM. >> >> This is another interesting information, isn't it? >> >> It is expected that the function “devm_kzalloc” has got a similar property. > > > You don't have to expect this. Go look at the definition of devm_kzalloc > and see whether it has the property or not. I find that the corresponding documentation of these programming interfaces is incomplete for a desired format which could be different than C source code. https://elixir.free-electrons.com/linux/v4.15-rc1/source/include/linux/device.h#L657 https://elixir.free-electrons.com/linux/v4.15-rc1/source/drivers/base/devres.c#L763 https://www.kernel.org/doc/html/latest/driver-api/basics.html#c.devm_kmalloc Can the Coccinelle software help more to determine desired function properties? >> For which hardware and software combinations would you like to see >> facts there? > > This is not for Joe to decide, This view is fine in principle. > it's for the person who receives the patch to decide. I am curious on further comments from these contributors. > You could start with the ones for which the code actually compiles, > using the standard make file and no special options, and a > recent version of gcc. The variation space could become too big to handle for me (alone). How will this aspect evolve further? Regards, Markus