From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B48FC433EF for ; Sat, 21 May 2022 14:05:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348464AbiEUOFO (ORCPT ); Sat, 21 May 2022 10:05:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346239AbiEUOFG (ORCPT ); Sat, 21 May 2022 10:05:06 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E686562EB for ; Sat, 21 May 2022 07:05:04 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id g16so12398383lja.3 for ; Sat, 21 May 2022 07:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=d1kYyv5ThMhL++IEPezH6L3/JQfTCn2bBC3uluzdASE=; b=zZBZG+77Ro4UojerpsPaGBJsTYHFLKxtpL9lewzUMg1c4KkDTo4DessCZvZOHpRba8 DYu7ITDh7Utd+YoskwDItroRXLSYDcUrhqkIeQ/L8wQ+n1ik1FLZPdKe9Yo5kPujQQvy HQXhDmawQgnVR/hhTssCDYriad6YcC7bqXo9Sq9jD4ZJfj5611kwAqmwKB6Vn8xP1FBG bbj2O/h+Dw/qHNLqZe7kU65yxuxlpmI6BH+c6QfWR8pqemXpQdk+H563662lR/JD/gCq dXNAgWllWX901z12Lr5leue7nNUq9DMmvum7jYf2AbVTbT2TXCdYSgQ2xU+iVXw0vYca zncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=d1kYyv5ThMhL++IEPezH6L3/JQfTCn2bBC3uluzdASE=; b=sIxNSmlOAbWkqB86eepUoHH1NS5kJ+j1sF5lpFZGrrrgxK9WQGs49Jc7vqDYPnfPZt Ov02Co5AOkaoLYvurw+egmPcPKS3lPN1SByHef6hnRtZQbcWnMcHg6WakimryIuNAeWy TtVeUV/6EWzlpLWKx9vmkMX0Noad1WnSXbblYpCFocBEz3+sQb4yW5pOu67pRj/oh/b7 CypcQyNl6u1CSxiBMUccUOHdqxglit2p+vkm+xXK7R95JrUdeyCGDlAV7/NBjN1RbK4v 6GAig1ja0I0SWgJchIn9jS1yHW3qXp0VTKAr8T92emRIV/Yks/AgZPTmTytRYfn0w6EB Ikxg== X-Gm-Message-State: AOAM530klhfPypWWKq4rwlx8PpVgh1OWGdbYvMKS9tlFsZF0YXYXTX8E IqIgthP6AD+HQqmfeiSRaqE6kw== X-Google-Smtp-Source: ABdhPJwZEhOHqoesMgIauedpx3ogq6lMvJjNB5YML4uG6u/SJasUNr+u1EP6LiAEWRpx4u0gHGXrOQ== X-Received: by 2002:a2e:9348:0:b0:249:7117:b7ad with SMTP id m8-20020a2e9348000000b002497117b7admr8023603ljh.85.1653141902955; Sat, 21 May 2022 07:05:02 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a4-20020ac25204000000b00477a1b603basm1068915lfl.98.2022.05.21.07.05.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 May 2022 07:05:02 -0700 (PDT) Message-ID: <288690ac-b23b-92f8-64b4-d994f249f21c@linaro.org> Date: Sat, 21 May 2022 16:05:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property Content-Language: en-US To: Rob Herring , AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sboyd@kernel.org, chun-jie.chen@mediatek.com, rex-bc.chen@mediatek.com, wenst@chromium.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220518093631.25491-1-angelogioacchino.delregno@collabora.com> <20220518093631.25491-3-angelogioacchino.delregno@collabora.com> <20220520221910.GA348732-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220520221910.GA348732-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/05/2022 00:19, Rob Herring wrote: > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: >> This is a clock-controller binding, so it needs #clock-cells, or >> it would be of no use: add that to the list of required properties. >> >> Signed-off-by: AngeloGioacchino Del Regno >> Reviewed-by: Matthias Brugger >> Reviewed-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + >> .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + >> .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + >> 6 files changed, 6 insertions(+) > > Acked-by: Rob Herring > > Wasn't there some discussion about moving these to bindings/clocks/? > Maybe that was another one, it's all a blur... Yes, there was such idea although I am not sure if this is worth by itself - messes up with the git history. Best regards, Krzysztof