From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B85C4C34022 for ; Thu, 27 Feb 2020 14:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E45924650 for ; Thu, 27 Feb 2020 14:55:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="CXaicGmY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731117AbgB0Ozf (ORCPT ); Thu, 27 Feb 2020 09:55:35 -0500 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.80]:29987 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729417AbgB0Oze (ORCPT ); Thu, 27 Feb 2020 09:55:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1582815330; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=6MaUNnuMF9ZzIkw9Sg6aeNx2guh8YptOPnOMLqWfXkQ=; b=CXaicGmYbo1aGBee6wD+cbXxGwb7F74DiM3TkV+omEtwXbKe3gqqwrgWHZGa0yGVKW xDbMzu02fzWRKOM0qN7ZJYMf0owt9h1/N6FcGfkhTm9FvDNd+88hn5GAgDNEfjt/G/ZW GRDVnL3GIE2I0vy6qqIFYVGY4cFu0Lm0fHKLrXv9NOeV7C9hUz0W7s3cfQkdk6hCwNqb nbT0XrwJ7izVT6bGtYNo9QgYxFffGmMl41ni4+UVU/SJOdYfmw/1fVi6G5hCleIVG/aY EgR2fd/A+Z8lVUnpTUTkX7rP0MRdubZuLk1wz94qsnmCYl2kH5qnUUuNMS9K+6yO5Vi4 0KmA== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHmMhw47o15Y=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 46.1.12 DYNA|AUTH) with ESMTPSA id U06217w1REtJBkm (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Thu, 27 Feb 2020 15:55:19 +0100 (CET) Subject: Re: [PATCH v6 2/6] Bindings: nvmem: add bindings for JZ4780 efuse Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=iso-8859-1 From: "H. Nikolaus Schaller" In-Reply-To: <1582814957.3.3@crapouillou.net> Date: Thu, 27 Feb 2020 15:55:19 +0100 Cc: PrasannaKumar Muralidharan , Andreas Kemnade , Mathieu Malaterre , Srinivas Kandagatla , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , Krzysztof Kozlowski , Kees Cook , Andi Kleen , Geert Uytterhoeven , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Content-Transfer-Encoding: quoted-printable Message-Id: <288EB071-1369-46ED-89F9-0A067FED0948@goldelico.com> References: <4b243cc120ca6f9a23e217d070e7f6a42f11f8b4.1582715761.git.hns@goldelico.com> <1582814957.3.3@crapouillou.net> To: Paul Cercueil X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 27.02.2020 um 15:49 schrieb Paul Cercueil : >=20 > Hi Nikolaus, >=20 >=20 > Le mer., f=E9vr. 26, 2020 at 12:15, H. Nikolaus Schaller = a =E9crit : >> From: PrasannaKumar Muralidharan >> This patch brings support for the JZ4780 efuse. Currently it only = exposes >> a read only access to the entire 8K bits efuse memory. >> Tested-by: Mathieu Malaterre >> Signed-off-by: PrasannaKumar Muralidharan = >> Signed-off-by: Mathieu Malaterre >> Signed-off-by: H. Nikolaus Schaller >> [converted to yaml] >> Signed-off-by: Andreas Kemnade >> --- >> .../bindings/nvmem/ingenic,jz4780-efuse.yaml | 50 = +++++++++++++++++++ >> 1 file changed, 50 insertions(+) >> create mode 100644 = Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml >> diff --git = a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml = b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml >> new file mode 100644 >> index 000000000000..b9c0ea09b335 >> --- /dev/null >> +++ = b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml >> @@ -0,0 +1,50 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/nvmem/ingenic,jz4780-efuse.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Ingenic JZ EFUSE driver bindings >> + >> +maintainers: >> + - PrasannaKumar Muralidharan >> + >> +allOf: >> + - $ref: "nvmem.yaml#" >> + >> +properties: >> + compatible: >> + enum: >> + - ingenic,jz4780-efuse >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + # Handle for the ahb for the efuse. >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: ahb2 >=20 > Your driver does not actually require the clock to be 'ahb2', it will = take the first clock independently of its name. So 'clock-names' can be = dropped. >=20 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + efuse@134100d0 { >> + compatible =3D "ingenic,jz4780-efuse"; >> + reg =3D <0x134100d0 0x2c>; >> + >> + clocks =3D <&cgu JZ4780_CLK_AHB2>; >> + clock-names =3D "ahb2"; >=20 > Same here. Ok! Will also update in the real .dts. BR and thanks, Nikolaus