From: Johannes Berg <johannes@sipsolutions.net>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Christian König" <christian.koenig@amd.com>,
"Huang Rui" <ray.huang@amd.com>,
dri-devel@lists.freedesktop.org, "Jeff Dike" <jdike@addtoit.com>,
"Richard Weinberger" <richard@nod.at>,
linux-um@lists.infradead.org, "David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/ttm: provide default page protection for UML
Date: Thu, 02 Sep 2021 09:43:33 +0200 [thread overview]
Message-ID: <288a2d4dbcb1e6b0fbeff6da86569aa92df09202.camel@sipsolutions.net> (raw)
In-Reply-To: <0887903c-483d-49c7-0d35-f59be2f85bac@cambridgegreys.com>
On Thu, 2021-09-02 at 07:19 +0100, Anton Ivanov wrote:
> > >
> > > I have a question though - why all of DRM is not !UML in config. Not
> > > like we can use them.
> >
> > I have no idea about that.
> > Hopefully one of the (other) UML maintainers can answer you.
>
> Touche.
>
> We will discuss that and possibly push a patch to !UML that part of the
> tree. IMHO it is not applicable.
As I just said on the other patch, all of this is fallout from my commit
68f5d3f3b654 ("um: add PCI over virtio emulation driver") which is the
first time that you could have PCI on UML.
Without having checked, in this particular case it's probably something
like
depends on PCI && X86_64
as we've seen in other drivers (idxd, ioat).
The biggest problem is probably that UML internally uses X86_64
(arch/x86/um/Kconfig), which is ... unexpected ... since CONFIG_X86_64
is typically considered the ARCH, and now the ARCH is actually um.
I think we can just fix that and get rid of this entire class of
problems? Something like
https://p.sipsolutions.net/fbac19d86637e286.txt
johannes
next prev parent reply other threads:[~2021-09-02 7:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 2:01 [PATCH] drm/ttm: provide default page protection for UML Randy Dunlap
2021-09-02 5:48 ` Anton Ivanov
2021-09-02 5:52 ` Randy Dunlap
2021-09-02 6:19 ` Anton Ivanov
2021-09-02 7:43 ` Johannes Berg [this message]
2021-09-02 8:10 ` Anton Ivanov
2021-09-02 8:11 ` Johannes Berg
2021-09-02 8:56 ` Christian König
2021-09-02 14:45 ` Daniel Vetter
2021-09-04 3:50 ` David Gow
2021-09-08 17:11 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=288a2d4dbcb1e6b0fbeff6da86569aa92df09202.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=airlied@linux.ie \
--cc=anton.ivanov@cambridgegreys.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=ray.huang@amd.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).