From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DC7C43217 for ; Wed, 12 Oct 2022 21:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230146AbiJLVUh (ORCPT ); Wed, 12 Oct 2022 17:20:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbiJLVUb (ORCPT ); Wed, 12 Oct 2022 17:20:31 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD39D1191DF for ; Wed, 12 Oct 2022 14:20:27 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id r14so27598567lfm.2 for ; Wed, 12 Oct 2022 14:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=svHmnwp/lBJXQfjmxrCgtPTSC6GLXx0JOQWMenb2G1c=; b=zmcRl90oW6WhKBDEMkFKHSfte3DVUDw2eERLCOBtU/VHE4a/BrKKjZIM8dC3FRrS8u Fd9XIJ9Rlij0/peJGTz+wmgoe3OhN+2NV+GOUnUeDFnSPLJ42EkzldGyxkMhnCftSV8c ftgYOl+WJ3KUC1EBWC8Bf8kYF5ZU0GFae3F4fU11QRm1xAtaOPdNFO82HSDihruysQBl mhqtfnwoQkhxcZvGYTv798Pg8mLe1rzHK72Uqp9mtOgix6sQ9JE3BeybqIE0mD3efs2i FpOBGruYRg+nvGVDbFCC+doJy/GkxrCsgmQBAt5z6OdESJZAPV3uyuBgYIK3tsUigrnQ cAog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=svHmnwp/lBJXQfjmxrCgtPTSC6GLXx0JOQWMenb2G1c=; b=JOEkCFAAJhmNydKS2Z13Fs/DrNkUNaZ7XyUW+yOe6z3fQNnfpuADFDubQla5EZFAI3 +p4dg5EVfAUeYg8UQ9LjHZL7qNAGg9zOIS4Vqsrn1r0LJpxFW6JQyOLPU/mPPh9LoDJk m7dw6DxzAPD6l1RH+vPpOAhDRnfVmIImxw/Ft5A8McJ4uGjq9qBdKGJr6XkTSjOwWNjS pWreyP8CQCdgPbmofqQQH2RTpAVXBjkf1WoqxaGyLnW9JcFN0DZPZjGRZro9JvIM0zRW 2Hbj4zmNxO2XuNtH15l6YEZhmHvoOuFOCkt7VMFFOs5sUcfCR3n/A3XLc6tKZluN79vI rxPQ== X-Gm-Message-State: ACrzQf1uYx9cjEXv9qTirkVJ9ynGndl0MGosHgjxoEMNj7OaA8xU5zUk oqzvgsTxvIUBG7z3FHf6+PNWpQ== X-Google-Smtp-Source: AMsMyM7/9QqBwj34F2NGtv6kWrKVz+vIBg0g+1GZq6HuwJq/qlTB2kWMjEspKXuUqv9v5CFkvh8UfQ== X-Received: by 2002:a05:6512:1156:b0:4a2:7e51:b3e0 with SMTP id m22-20020a056512115600b004a27e51b3e0mr11408835lfg.118.1665609625195; Wed, 12 Oct 2022 14:20:25 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id q66-20020a2e5c45000000b0026b2094f6fcsm122880ljb.73.2022.10.12.14.20.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 14:20:24 -0700 (PDT) Message-ID: <289149bb-2620-efd4-8a3b-831215b0a8d8@linaro.org> Date: Thu, 13 Oct 2022 00:20:24 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 17/20] phy: qcom-qmp-pcie: add config sanity checks Content-Language: en-GB To: Johan Hovold , Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221012084846.24003-1-johan+linaro@kernel.org> <20221012085002.24099-1-johan+linaro@kernel.org> <20221012085002.24099-17-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20221012085002.24099-17-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/2022 11:49, Johan Hovold wrote: > The driver expects every configuration to set the pwrdn_ctrl and > phy_status masks. Add some probe WARN_ON_ONCE() to probe to catch any > new driver support that fails to provide them. > > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry