From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F47CC43461 for ; Wed, 5 May 2021 20:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0784D60241 for ; Wed, 5 May 2021 20:11:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233878AbhEEUML (ORCPT ); Wed, 5 May 2021 16:12:11 -0400 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:44757 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233852AbhEEUMK (ORCPT ); Wed, 5 May 2021 16:12:10 -0400 Received: from [192.168.1.18] ([86.243.172.93]) by mwinf5d16 with ME id 18BC2500121Fzsu038BCd0; Wed, 05 May 2021 22:11:12 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 05 May 2021 22:11:12 +0200 X-ME-IP: 86.243.172.93 Subject: Re: [PATCH] media: i2c: ov2659: Fix an error message To: prabhakar.csengg@gmail.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, bparrot@ti.com, hans.verkuil@cisco.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <1ed22753cd773e68e56c78eca01713d781097ffb.1620244953.git.christophe.jaillet@wanadoo.fr> From: Christophe JAILLET Message-ID: <289cde95-da39-71ed-b9eb-84aa3bdd0fa3@wanadoo.fr> Date: Wed, 5 May 2021 22:11:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <1ed22753cd773e68e56c78eca01713d781097ffb.1620244953.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 05/05/2021 à 22:03, Christophe JAILLET a écrit : > 'ret' is known to be 0 here and printing -ENODEV wouldn't be really > helpful. > So, print something that may be helpful instead. > > Fixes: c4c0283ab3cd ("[media] media: i2c: add support for omnivision's ov2659 sensor") > Signed-off-by: Christophe JAILLET > --- > drivers/media/i2c/ov2659.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c > index 42f64175a6df..96bda172b334 100644 > --- a/drivers/media/i2c/ov2659.c > +++ b/drivers/media/i2c/ov2659.c > @@ -1368,8 +1368,8 @@ static int ov2659_detect(struct v4l2_subdev *sd) > id = OV265X_ID(pid, ver); > if (id != OV2659_ID) { > dev_err(&client->dev, > - "Sensor detection failed (%04X, %d)\n", > - id, ret); > + "Sensor detection failed (id=%04X, pid=%X, ver=%X)\n", > + id, (int)pid, (int)ver); > ret = -ENODEV; > } else { > dev_info(&client->dev, "Found OV%04X sensor\n", id); > NACK. I should have looked at OV265X_ID before sending the patch. I'll send a v2 that just removes 'ret'. CJ