From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
konrad.wilk@oracle.com, roger.pau@citrix.com, axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer
Date: Thu, 27 Sep 2018 09:12:56 +0200 [thread overview]
Message-ID: <28aa9249-7406-21c6-f509-65411828e2d7@suse.com> (raw)
In-Reply-To: <20180922195549.27953-1-boris.ostrovsky@oracle.com>
On 22/09/18 21:55, Boris Ostrovsky wrote:
> Commit a46b53672b2c ("xen/blkfront: cleanup stale persistent grants")
> added support for purging persistent grants when they are not in use. As
> part of the purge, the grants were removed from the grant buffer, This
> eventually causes the buffer to become empty, with BUG_ON triggered in
> get_free_grant(). This can be observed even on an idle system, within
> 20-30 minutes.
>
> We should keep the grants in the buffer when purging, and only free the
> grant ref.
>
> Fixes: a46b53672b2c ("xen/blkfront: cleanup stale persistent grants")
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
next prev parent reply other threads:[~2018-09-27 7:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 19:55 [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer Boris Ostrovsky
2018-09-27 7:12 ` Juergen Gross [this message]
2018-09-27 14:26 ` Jens Axboe
2018-09-27 18:52 ` [Xen-devel] " Sander Eikelenboom
2018-09-27 18:56 ` Jens Axboe
2018-09-27 19:06 ` Boris Ostrovsky
2018-09-27 19:16 ` Jens Axboe
2018-09-27 20:33 ` Sander Eikelenboom
2018-09-27 21:37 ` Jens Axboe
2018-09-27 21:48 ` Boris Ostrovsky
2018-09-27 22:03 ` Sander Eikelenboom
2018-09-28 6:44 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28aa9249-7406-21c6-f509-65411828e2d7@suse.com \
--to=jgross@suse.com \
--cc=axboe@kernel.dk \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).