From: Chenyi Qiang <chenyi.qiang@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Xiaoyao Li <xiaoyao.li@intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND RFC v2 0/2] add bus lock VM exit support
Date: Wed, 26 Aug 2020 17:57:45 +0800 [thread overview]
Message-ID: <28b3864d-8cc2-a062-5d29-4f92dce74630@intel.com> (raw)
In-Reply-To: <20200817033604.5836-1-chenyi.qiang@intel.com>
Ping for comments
On 8/17/2020 11:36 AM, Chenyi Qiang wrote:
> Resend to rebase on 5.9-rc1.
>
> ---
>
> Add the support for bus lock VM exit in KVM. It is a sub-feature of bus
> lock detection. Another sub-feature named bus lock debug exception is
> blocked due to requirement to rework the HW design:
> https://lore.kernel.org/lkml/87r1stmi1x.fsf@nanos.tec.linutronix.de/
>
> In this patch series, the first patch applies Sean's refactor to
> vcpu_vmx.exit_reason available at
> https://patchwork.kernel.org/patch/11500659.
> It is necessary as bus lock VM exit adds a new modifier bit(bit 26) in
> exit_reason field in VMCS.
>
> The second patch is the enabling work for bus lock VM exit. Add the
> support to set the capability to enable bus lock vm exit. The current
> implementation just exit to user space when handling the bus lock
> detected in guest.
>
> The concrete throttling policy in user space still needs to be
> discussed. We can enforce ratelimit on bus lock in guest, just inject
> some sleep time, or any other ideas?
>
> Document for Bus Lock Detection is now available at the latest "Intel
> Architecture Instruction Set Extensions Programming Reference".
>
> Document Link:
> https://software.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-programming-reference.html
>
>
> v1->v2 Changelogs:
> - resolve Vitaly's comment to introduce the KVM_EXIT_BUS_LOCK and a
> capability to enable it.
> - add the support to exit to user space when handling bus locks.
> - extend the vcpu->run->flags to indicate bus lock detected for other
> exit reasons when exiting to user space.
>
> Chenyi Qiang (1):
> KVM: VMX: Enable bus lock VM exit
>
> Sean Christopherson (1):
> KVM: VMX: Convert vcpu_vmx.exit_reason to a union
>
> arch/x86/include/asm/kvm_host.h | 9 +++
> arch/x86/include/asm/vmx.h | 1 +
> arch/x86/include/asm/vmxfeatures.h | 1 +
> arch/x86/include/uapi/asm/kvm.h | 1 +
> arch/x86/include/uapi/asm/vmx.h | 4 +-
> arch/x86/kvm/vmx/capabilities.h | 6 ++
> arch/x86/kvm/vmx/nested.c | 42 ++++++++-----
> arch/x86/kvm/vmx/vmx.c | 97 ++++++++++++++++++++----------
> arch/x86/kvm/vmx/vmx.h | 25 +++++++-
> arch/x86/kvm/x86.c | 36 ++++++++++-
> arch/x86/kvm/x86.h | 5 ++
> include/uapi/linux/kvm.h | 2 +
> 12 files changed, 179 insertions(+), 50 deletions(-)
>
prev parent reply other threads:[~2020-08-26 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 3:36 [RESEND RFC v2 0/2] add bus lock VM exit support Chenyi Qiang
2020-08-17 3:36 ` [RESEND RFC v2 1/2] KVM: VMX: Convert vcpu_vmx.exit_reason to a union Chenyi Qiang
2020-08-17 3:36 ` [RESEND RFC v2 2/2] KVM: VMX: Enable bus lock VM exit Chenyi Qiang
2020-08-26 9:57 ` Chenyi Qiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28b3864d-8cc2-a062-5d29-4f92dce74630@intel.com \
--to=chenyi.qiang@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).