linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Slark Xiao" <slark_xiao@163.com>
To: "Greg KH" <gregkh@linuxfoundation.org>
Cc: mani@kernel.org, loic.poulain@linaro.org, dnlplm@gmail.com,
	yonglin.tan@outlook.com, fabio.porcedda@gmail.com,
	mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH v2] bus: mhi: host: pci_generic: Add macro for some VIDs
Date: Mon, 7 Nov 2022 17:30:56 +0800 (CST)	[thread overview]
Message-ID: <28f1e702.28d7.184516dbbbb.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <Y2jJpT5//xBUOQMq@kroah.com>

















At 2022-11-07 17:02:29, "Greg KH" <gregkh@linuxfoundation.org> wrote:
>On Mon, Nov 07, 2022 at 04:48:26PM +0800, Slark Xiao wrote:
>> To make code neat and for convenience purpose, use macro for
>> some VIDs. These macros are supposed to be added to pci_ids.h.
>
>No, they are not supposed to be added there at all.
>
>And they are not a "macro", it is a "#define".
>
>> But until the macros are used in multiple places, it is not
>> recommended. So adding it locally for now.
>
>Again, these are not macros
>
>thanks,
>
>greg k-h

Hi Greg,
Thanks for your comment.
In my opinion, MACRO almost same as a '#define'.  May I know how do 
you call such definition?

And could you give your comments in previous patch, not the 'final' one?
In another pci_ids patch, you break it in v3 and break it here again in v2.
Honestly,  it's positive for whole project. But it's negative  for contributor 
and maintainer. 

Finally, it's welcome to point out the error. 

  reply	other threads:[~2022-11-07  9:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07  8:48 [PATCH v2] bus: mhi: host: pci_generic: Add macro for some VIDs Slark Xiao
2022-11-07  9:02 ` Greg KH
2022-11-07  9:30   ` Slark Xiao [this message]
2022-11-07  9:53     ` Greg KH
2022-11-07 10:26       ` Slark Xiao
2022-11-07 12:07         ` Greg KH
2022-11-10 11:14           ` Slark Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28f1e702.28d7.184516dbbbb.Coremail.slark_xiao@163.com \
    --to=slark_xiao@163.com \
    --cc=dnlplm@gmail.com \
    --cc=fabio.porcedda@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=mani@kernel.org \
    --cc=mhi@lists.linux.dev \
    --cc=yonglin.tan@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).