From: "Daniel Almeida" <daniel.almeida@collabora.com>
To: "Alice Ryhl" <aliceryhl@google.com>
Cc: wedsonaf@gmail.com, ojeda@kernel.org, mchehab@kernel.org,
hverkuil@xs4all.nl, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
kernel@collabora.com
Subject: Re: [RFC PATCH 1/1] v4l2-core: rewrite the VP9 library in Rust
Date: Wed, 28 Feb 2024 17:59:35 +0000 [thread overview]
Message-ID: <28f4-65df7480-b-5f6f8180@243208659> (raw)
In-Reply-To: <CAH5fLgi_Y0a=XPtgdiA9KcsmMGxn=DjvLMmSq-UF8VQtZVTccg@mail.gmail.com>
Hi Alice!
On Wednesday, February 28, 2024 11:13 -03, Alice Ryhl <aliceryhl@google.com> wrote:
> I recommend taking an `*mut u8` here instead of `&mut u8` if you're
> going to use `slice::from_raw_parts_mut`. Or, if cbindgen allows it,
> take an `&mut [u8; 8]` instead and eliminate the unsafe block.
You're right, the signature here can change to `&mut [u8; 8]` instead. This means no unsafe blocks at all.
Thanks for the tip,
-- Daniel
next prev parent reply other threads:[~2024-02-28 17:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 21:51 [RFC PATCH 0/1] Rewrite the VP9 codec library in Rust Daniel Almeida
2024-02-27 21:51 ` [RFC PATCH 1/1] v4l2-core: rewrite the VP9 " Daniel Almeida
2024-02-28 14:13 ` Alice Ryhl
2024-02-28 17:59 ` Daniel Almeida [this message]
2024-03-07 19:08 ` [RFC PATCH v2 0/2] Rewrite parts of rkvdec driver and the VP9 codec " Daniel Almeida
2024-03-07 19:08 ` [RFC PATCH v2 1/2] v4l2-core: rewrite the VP9 " Daniel Almeida
2024-03-07 19:08 ` [RFC PATCH v2 2/2] media: rkvdec: rewrite parts of the driver " Daniel Almeida
2024-03-07 20:56 ` Nicolas Dufresne
2024-03-07 21:45 ` Daniel Almeida
2024-03-07 20:04 ` [RFC PATCH v2 0/2] Rewrite parts of rkvdec driver and the VP9 codec library " Deborah Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28f4-65df7480-b-5f6f8180@243208659 \
--to=daniel.almeida@collabora.com \
--cc=aliceryhl@google.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).