From: Qian Cai <cai@lca.pw>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] x86_64: increase stack size for KASAN_EXTRA
Date: Wed, 9 Jan 2019 23:20:49 -0500 [thread overview]
Message-ID: <291d9d64-9eb7-517e-9ae7-30e8cc3f672a@lca.pw> (raw)
In-Reply-To: <20190109140201.4434ff87880ee29bdedb37cc@linux-foundation.org>
On 1/9/19 5:02 PM, Andrew Morton wrote:
>> --- a/arch/x86/include/asm/page_64_types.h
>> +++ b/arch/x86/include/asm/page_64_types.h
>> @@ -7,7 +7,11 @@
>> #endif
>>
>> #ifdef CONFIG_KASAN
>> +#ifdef CONFIG_KASAN_EXTRA
>> +#define KASAN_STACK_ORDER 2
>> +#else
>> #define KASAN_STACK_ORDER 1
>> +#endif
>> #else
>> #define KASAN_STACK_ORDER 0
>> #endif
>
> I'm suspecting this logic could be performed in Kconfig, for all
> architectures. Add a new always-defined CONFIG_KASAN_STACK_ORDER?
>
Sounds doable, but KASAN only support x86_64, arm64, s390 and xtensa so far. I
am not sure I care about the later two nor I have any way to test them if they
suffer the same problem.
I'll keep looking if more arches start to implement KASAN, and then might be a
good time to reduce all those code duplication.
next prev parent reply other threads:[~2019-01-10 4:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 2:06 [PATCH] x86_64: increase stack size for KASAN_EXTRA Qian Cai
2019-01-09 21:52 ` [RESEND PATCH] " Qian Cai
2019-01-09 22:02 ` Andrew Morton
2019-01-10 4:20 ` Qian Cai [this message]
2019-01-11 18:55 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=291d9d64-9eb7-517e-9ae7-30e8cc3f672a@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).